Skip to content

fix: respect core.hooksPath git config in commit hooks #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mangodxd wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix: respect core.hooksPath git config in commit hooks #2173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion git/index/fun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,21 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:
Arguments passed to hook file.

:raise git.exc.HookExecutionError:

:note:
Respects the ``core.hooksPath`` git configuration option. When set, hooks are
resolved relative to that path instead of the default ``.git/hooks`` directory.
"""
hp = hook_path(name, index.repo.git_dir)
hooks_path = index.repo.config_reader().get(
"core", "hooksPath", fallback=None
)
if hooks_path is not None:
hp = osp.join(hooks_path, name)
if not osp.isabs(hooks_path):
# Relative hooksPath is resolved against the working tree root.
hp = osp.join(index.repo.working_dir, hp)
else:
hp = hook_path(name, index.repo.git_dir)
if not os.access(hp, os.X_OK):
return

Expand Down
Loading