fix: make "test push webhook" always work#38425
Open
Otto-Deviant1904 wants to merge 4 commits into
Open
Conversation
GiteaBot
added
the
lgtm/need 2
Contributor
|
Instead of adding more "checks", I think it needs to re-design the "test webhook" button's behavior. It should always send something useful to test the webhook. |
PrepareWebhook skips when a webhook is not subscribed to the event or when the branch filter excludes the ref. The Test Push Event control is meant to verify the endpoint, so it now goes through PrepareTestWebhook, which always creates and enqueues a hook task. Real event delivery is unchanged. Adds a regression test covering a webhook with no push subscription and a non-matching branch filter. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Good call. I redesigned it so Test Push Event always enqueues a delivery via Pushed the update (rebased on current main). Happy to adjust further if you'd rather the test pick an enabled event type instead of always using a push payload. |
Otto-Deviant1904
force-pushed
the
fix/webhook-test-push-silent-skip
branch
from
85156cb to
f52112a
Compare
wxiaoguang
changed the title
wxiaoguang
approved these changes
Jul 14, 2026
GiteaBot
added
lgtm/need 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.