Skip to content

WEB-4512 Rebranding fixes#110

Merged
czechian merged 1 commit into
masterfrom
rebranding-fixes
Jul 23, 2026
Merged

WEB-4512 Rebranding fixes#110
czechian merged 1 commit into
masterfrom
rebranding-fixes

Conversation

@czechian

@czechian czechian commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes

    • Improved the appearance of the mobile menu icon in dark mode for better visibility.
    • Corrected dark-theme input backgrounds to render consistently across supported controls.
  • Style

    • Improved header layout alignment by ensuring the logo and navigation area use the available header height.
    • Simplified footer banner and button styling for more consistent spacing and alignment.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

SCSS updates refine header and logo sizing, dark-theme control and mobile-menu icon rendering, and footer banner spacing overrides.

Changes

SCSS styling updates

Layer / File(s) Summary
Header and logo sizing
assets/scss/header.scss
The header navigation container, logo, and nested SVG now use height: 100%.
Dark-theme control rendering
assets/scss/dark-theme/header.scss, assets/scss/dark-theme/menu.scss
Dark-theme inputs use background-color, and the mobile menu icon receives a brightness/invert filter.
Footer banner spacing
assets/scss/_styles_project.scss
Footer banner item margin and max-width overrides, plus nested footer button alignment and padding overrides, are removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Poem

A rabbit hops through styles anew,
Full-height logos come into view.
Dark icons shine, inputs stay bright,
Footer spacing settles right.
Hop, hop—clean CSS takes flight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the theme of the changeset, which consists of branding-related stylesheet fixes across header, menu, and footer styles.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@assets/scss/header.scss`:
- Around line 109-112: Update the header sizing around `&__left` so its `height:
100%` has a definite `.gd-docs-header-nav__first` height reference, either by
assigning an explicit header-row height or using stretch-based sizing; ensure
the nested `&__logo` receives reliable vertical sizing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b9b78334-758f-46d1-b8d2-27d5094d1f61

📥 Commits

Reviewing files that changed from the base of the PR and between bfbbbba and 34c1774.

📒 Files selected for processing (4)
  • assets/scss/_styles_project.scss
  • assets/scss/dark-theme/header.scss
  • assets/scss/dark-theme/menu.scss
  • assets/scss/header.scss
💤 Files with no reviewable changes (1)
  • assets/scss/_styles_project.scss

Comment thread assets/scss/header.scss
Comment on lines 109 to 112
&__left {
display: flex;
height: 100%;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

git ls-files assets/scss/header.scss
echo '---'
cat -n assets/scss/header.scss | sed -n '1,220p'

Repository: gooddata/gooddata-docs-theme

Length of output: 5936


🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n "gd-docs-header-nav__first|header-first-nav-height|height: 100%;" assets/scss assets -g '*.scss' -g '*.css'

Repository: gooddata/gooddata-docs-theme

Length of output: 3536


Give .gd-docs-header-nav__first a definite height before relying on height: 100% here.
min-height doesn’t give &__left / &__logo a reliable percentage-height reference, so the logo can still fall back to auto in this layout. Set an explicit header-row height or switch this to stretch-based sizing.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@assets/scss/header.scss` around lines 109 - 112, Update the header sizing
around `&__left` so its `height: 100%` has a definite
`.gd-docs-header-nav__first` height reference, either by assigning an explicit
header-row height or using stretch-based sizing; ensure the nested `&__logo`
receives reliable vertical sizing.

@czechian
czechian merged commit e5bb4dd into master Jul 23, 2026
2 checks passed
@czechian
czechian deleted the rebranding-fixes branch July 23, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants