WEB-4512 Rebranding fixes#110
Conversation
📝 WalkthroughWalkthroughSCSS updates refine header and logo sizing, dark-theme control and mobile-menu icon rendering, and footer banner spacing overrides. ChangesSCSS styling updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/scss/header.scss`:
- Around line 109-112: Update the header sizing around `&__left` so its `height:
100%` has a definite `.gd-docs-header-nav__first` height reference, either by
assigning an explicit header-row height or using stretch-based sizing; ensure
the nested `&__logo` receives reliable vertical sizing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b9b78334-758f-46d1-b8d2-27d5094d1f61
📒 Files selected for processing (4)
assets/scss/_styles_project.scssassets/scss/dark-theme/header.scssassets/scss/dark-theme/menu.scssassets/scss/header.scss
💤 Files with no reviewable changes (1)
- assets/scss/_styles_project.scss
| &__left { | ||
| display: flex; | ||
| height: 100%; | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
git ls-files assets/scss/header.scss
echo '---'
cat -n assets/scss/header.scss | sed -n '1,220p'Repository: gooddata/gooddata-docs-theme
Length of output: 5936
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n "gd-docs-header-nav__first|header-first-nav-height|height: 100%;" assets/scss assets -g '*.scss' -g '*.css'Repository: gooddata/gooddata-docs-theme
Length of output: 3536
Give .gd-docs-header-nav__first a definite height before relying on height: 100% here.
min-height doesn’t give &__left / &__logo a reliable percentage-height reference, so the logo can still fall back to auto in this layout. Set an explicit header-row height or switch this to stretch-based sizing.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@assets/scss/header.scss` around lines 109 - 112, Update the header sizing
around `&__left` so its `height: 100%` has a definite
`.gd-docs-header-nav__first` height reference, either by assigning an explicit
header-row height or using stretch-based sizing; ensure the nested `&__logo`
receives reliable vertical sizing.
Summary by CodeRabbit
Bug Fixes
Style