docs: Rebranding#1696
Open
czechian wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughDocumentation builds now expose ChangesDocumentation theme migration
Estimated code review effort: 4 (Complex) | ~45 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/netlify-deploy-v2.yaml:
- Line 129: Remove the lowercase hugo_env YAML key and prefix the Hugo command
with hugo_env=public in .github/workflows/netlify-deploy-v2.yaml at lines
129-129. Apply the same change in
.github/actions/hugo-build-versioned-action/action.yaml at lines 81-81, while
preserving the existing uppercase HUGO_ENV key.
In `@docs/assets/scss/_local-overrides.scss`:
- Line 2: Remove the empty comment from _local-overrides.scss and update the
color keyword spelling to the repository-required lowercase currentcolor
wherever it appears, ensuring the stylesheet passes Stylelint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ce0777e3-7d97-4771-a165-5eaa142637e5
⛔ Files ignored due to path filters (23)
docs/assets/icons/chevron-menu.svgis excluded by!**/*.svgdocs/assets/icons/chevron.svgis excluded by!**/*.svgdocs/assets/icons/docs-icon.svgis excluded by!**/*.svgdocs/assets/icons/slack.svgis excluded by!**/*.svgdocs/go.sumis excluded by!**/*.sumdocs/static/figures/different-use-cases.pngis excluded by!**/*.pngdocs/static/figures/gd-relationship.pngis excluded by!**/*.pngdocs/static/figures/gd-use-cases.pngis excluded by!**/*.pngdocs/static/img/arrow-right.svgis excluded by!**/*.svgdocs/static/img/burger.svgis excluded by!**/*.svgdocs/static/img/close.svgis excluded by!**/*.svgdocs/static/img/copy.svgis excluded by!**/*.svgdocs/static/img/dropdown.svgis excluded by!**/*.svgdocs/static/img/icon-accelerator-toolkit.svgis excluded by!**/*.svgdocs/static/img/icon-community.svgis excluded by!**/*.svgdocs/static/img/icon-examples-gallery.svgis excluded by!**/*.svgdocs/static/img/icon-gooddata-ui-documentation.svgis excluded by!**/*.svgdocs/static/img/icon-hosted.svgis excluded by!**/*.svgdocs/static/img/icon-interactive-code-samples.svgis excluded by!**/*.svgdocs/static/img/icon-slack.svgis excluded by!**/*.svgdocs/static/img/icon-university.svgis excluded by!**/*.svgdocs/static/img/share.svgis excluded by!**/*.svgdocs/static/img/video-play.svgis excluded by!**/*.svg
📒 Files selected for processing (77)
.github/actions/hugo-build-versioned-action/action.yaml.github/workflows/netlify-deploy-v2.yamldocs/assets/js/base.jsdocs/assets/json/offline-search-index.jsondocs/assets/scss/_local-overrides.scssdocs/assets/scss/_styles_project.scssdocs/assets/scss/alert.scssdocs/assets/scss/content-select.scssdocs/assets/scss/functions/_functions.pxtorem.scssdocs/assets/scss/header.scssdocs/assets/scss/homepage.scssdocs/assets/scss/homepage/box.scssdocs/assets/scss/homepage/hosted.scssdocs/assets/scss/homepage/icons.scssdocs/assets/scss/homepage/learn.scssdocs/assets/scss/homepage/sections-list.scssdocs/assets/scss/homepage/slack.scssdocs/assets/scss/mixins/_mixins.media-queries.scssdocs/assets/scss/prev-next-pages.scssdocs/assets/scss/share-dialog.scssdocs/assets/scss/swagger.scssdocs/assets/scss/tables.scssdocs/assets/scss/toc.scssdocs/assets/scss/tooltip.scssdocs/assets/scss/typography.scssdocs/assets/scss/variables/_variables.colors.scssdocs/assets/scss/variables/_variables.footer.scssdocs/assets/scss/variables/_variables.media-queries.scssdocs/assets/scss/variables/_variables.scssdocs/config/_default/config.tomldocs/config/_default/menus.tomldocs/go.moddocs/layouts/404.htmldocs/layouts/_default/_markup/render-image.htmldocs/layouts/_default/_markup/render-link.htmldocs/layouts/_default/baseof.htmldocs/layouts/_default/content.htmldocs/layouts/docs/baseof.htmldocs/layouts/partials/article-label.htmldocs/layouts/partials/custom-related-content.htmldocs/layouts/partials/favicons.htmldocs/layouts/partials/footer.htmldocs/layouts/partials/gtm-body.htmldocs/layouts/partials/gtm.htmldocs/layouts/partials/head-css.htmldocs/layouts/partials/head.htmldocs/layouts/partials/header-menu.htmldocs/layouts/partials/hooks/body-end.htmldocs/layouts/partials/hooks/head-end.htmldocs/layouts/partials/navbar.htmldocs/layouts/partials/prev-next-pages.htmldocs/layouts/partials/share-dialog.htmldocs/layouts/partials/toc.htmldocs/layouts/shortcodes/alert.htmldocs/layouts/shortcodes/blocks/card.htmldocs/layouts/shortcodes/blocks/cards-container.htmldocs/layouts/shortcodes/blocks/feature.htmldocs/layouts/shortcodes/blocks/homepage-hosted.htmldocs/layouts/shortcodes/blocks/homepage-learn.htmldocs/layouts/shortcodes/blocks/homepage-slack.htmldocs/layouts/shortcodes/blocks/section.htmldocs/layouts/shortcodes/blocks/sections-list.htmldocs/layouts/shortcodes/code-lang.htmldocs/layouts/shortcodes/code-select.htmldocs/layouts/shortcodes/content-block.htmldocs/layouts/shortcodes/content-select.htmldocs/layouts/shortcodes/inline-icon.htmldocs/layouts/shortcodes/label.htmldocs/layouts/shortcodes/latest-doc-dirpath.htmldocs/layouts/shortcodes/latesttag.htmldocs/layouts/shortcodes/product.htmldocs/layouts/shortcodes/swaggerui.htmldocs/layouts/swagger/baseof.htmldocs/static/js/pactsafe.jsdocs/static/js/prism.jsdocs/static/js/share.jsdocs/static/js/tables.js
💤 Files with no reviewable changes (65)
- docs/layouts/partials/header-menu.html
- docs/layouts/partials/gtm-body.html
- docs/layouts/shortcodes/blocks/homepage-slack.html
- docs/layouts/shortcodes/code-select.html
- docs/layouts/partials/toc.html
- docs/layouts/_default/baseof.html
- docs/layouts/shortcodes/code-lang.html
- docs/assets/scss/homepage/slack.scss
- docs/layouts/partials/article-label.html
- docs/assets/scss/share-dialog.scss
- docs/layouts/swagger/baseof.html
- docs/assets/scss/tables.scss
- docs/assets/scss/content-select.scss
- docs/layouts/shortcodes/label.html
- docs/assets/scss/typography.scss
- docs/assets/scss/homepage/icons.scss
- docs/assets/scss/homepage/sections-list.scss
- docs/assets/scss/alert.scss
- docs/layouts/shortcodes/blocks/feature.html
- docs/assets/scss/functions/_functions.pxtorem.scss
- docs/assets/scss/homepage/hosted.scss
- docs/layouts/partials/custom-related-content.html
- docs/assets/scss/header.scss
- docs/layouts/shortcodes/blocks/homepage-hosted.html
- docs/assets/scss/prev-next-pages.scss
- docs/layouts/shortcodes/blocks/cards-container.html
- docs/static/js/share.js
- docs/layouts/shortcodes/blocks/homepage-learn.html
- docs/layouts/partials/favicons.html
- docs/layouts/partials/share-dialog.html
- docs/assets/scss/homepage/learn.scss
- docs/layouts/partials/gtm.html
- docs/layouts/shortcodes/product.html
- docs/layouts/_default/_markup/render-image.html
- docs/layouts/partials/footer.html
- docs/layouts/shortcodes/alert.html
- docs/layouts/shortcodes/blocks/card.html
- docs/layouts/shortcodes/latest-doc-dirpath.html
- docs/layouts/shortcodes/blocks/section.html
- docs/layouts/partials/head-css.html
- docs/assets/scss/mixins/_mixins.media-queries.scss
- docs/layouts/_default/_markup/render-link.html
- docs/layouts/shortcodes/content-block.html
- docs/layouts/docs/baseof.html
- docs/layouts/shortcodes/blocks/sections-list.html
- docs/assets/scss/homepage.scss
- docs/assets/scss/homepage/box.scss
- docs/layouts/shortcodes/content-select.html
- docs/assets/json/offline-search-index.json
- docs/assets/scss/variables/_variables.media-queries.scss
- docs/assets/scss/toc.scss
- docs/layouts/partials/prev-next-pages.html
- docs/static/js/tables.js
- docs/layouts/shortcodes/swaggerui.html
- docs/assets/scss/tooltip.scss
- docs/assets/scss/swagger.scss
- docs/layouts/404.html
- docs/layouts/shortcodes/inline-icon.html
- docs/layouts/shortcodes/latesttag.html
- docs/layouts/partials/head.html
- docs/static/js/prism.js
- docs/static/js/pactsafe.js
- docs/assets/scss/variables/_variables.footer.scss
- docs/assets/scss/variables/_variables.scss
- docs/assets/scss/variables/_variables.colors.scss
| @@ -0,0 +1,233 @@ | |||
| // Project-local overrides layered on top of gooddata-docs-theme. | |||
| // | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Resolve the reported Stylelint errors.
Remove the empty comment and use the repository-required currentcolor spelling so this stylesheet passes linting.
Proposed fix
-//
...
- fill: currentColor;
+ fill: currentcolor;Also applies to: 74-74
🧰 Tools
🪛 Stylelint (17.14.0)
[error] 2-2: Unexpected empty comment (scss/comment-no-empty)
(scss/comment-no-empty)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/assets/scss/_local-overrides.scss` at line 2, Remove the empty comment
from _local-overrides.scss and update the color keyword spelling to the
repository-required lowercase currentcolor wherever it appears, ensuring the
stylesheet passes Stylelint.
Source: Linters/SAST tools
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/assets/scss/_local-overrides.scss`:
- Around line 213-221: Add pointer-events: none to the &::after overlay inside
&__inner so the right-edge gradient does not intercept horizontal scrollbar
interaction.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f7ba10f4-2483-41dd-9fde-ddf6fcf8069b
⛔ Files ignored due to path filters (23)
docs/assets/icons/chevron-menu.svgis excluded by!**/*.svgdocs/assets/icons/chevron.svgis excluded by!**/*.svgdocs/assets/icons/docs-icon.svgis excluded by!**/*.svgdocs/assets/icons/slack.svgis excluded by!**/*.svgdocs/go.sumis excluded by!**/*.sumdocs/static/figures/different-use-cases.pngis excluded by!**/*.pngdocs/static/figures/gd-relationship.pngis excluded by!**/*.pngdocs/static/figures/gd-use-cases.pngis excluded by!**/*.pngdocs/static/img/arrow-right.svgis excluded by!**/*.svgdocs/static/img/burger.svgis excluded by!**/*.svgdocs/static/img/close.svgis excluded by!**/*.svgdocs/static/img/copy.svgis excluded by!**/*.svgdocs/static/img/dropdown.svgis excluded by!**/*.svgdocs/static/img/icon-accelerator-toolkit.svgis excluded by!**/*.svgdocs/static/img/icon-community.svgis excluded by!**/*.svgdocs/static/img/icon-examples-gallery.svgis excluded by!**/*.svgdocs/static/img/icon-gooddata-ui-documentation.svgis excluded by!**/*.svgdocs/static/img/icon-hosted.svgis excluded by!**/*.svgdocs/static/img/icon-interactive-code-samples.svgis excluded by!**/*.svgdocs/static/img/icon-slack.svgis excluded by!**/*.svgdocs/static/img/icon-university.svgis excluded by!**/*.svgdocs/static/img/share.svgis excluded by!**/*.svgdocs/static/img/video-play.svgis excluded by!**/*.svg
📒 Files selected for processing (77)
.github/actions/hugo-build-versioned-action/action.yaml.github/workflows/netlify-deploy-v2.yamldocs/assets/js/base.jsdocs/assets/json/offline-search-index.jsondocs/assets/scss/_local-overrides.scssdocs/assets/scss/_styles_project.scssdocs/assets/scss/alert.scssdocs/assets/scss/content-select.scssdocs/assets/scss/functions/_functions.pxtorem.scssdocs/assets/scss/header.scssdocs/assets/scss/homepage.scssdocs/assets/scss/homepage/box.scssdocs/assets/scss/homepage/hosted.scssdocs/assets/scss/homepage/icons.scssdocs/assets/scss/homepage/learn.scssdocs/assets/scss/homepage/sections-list.scssdocs/assets/scss/homepage/slack.scssdocs/assets/scss/mixins/_mixins.media-queries.scssdocs/assets/scss/prev-next-pages.scssdocs/assets/scss/share-dialog.scssdocs/assets/scss/swagger.scssdocs/assets/scss/tables.scssdocs/assets/scss/toc.scssdocs/assets/scss/tooltip.scssdocs/assets/scss/typography.scssdocs/assets/scss/variables/_variables.colors.scssdocs/assets/scss/variables/_variables.footer.scssdocs/assets/scss/variables/_variables.media-queries.scssdocs/assets/scss/variables/_variables.scssdocs/config/_default/config.tomldocs/config/_default/menus.tomldocs/go.moddocs/layouts/404.htmldocs/layouts/_default/_markup/render-image.htmldocs/layouts/_default/_markup/render-link.htmldocs/layouts/_default/baseof.htmldocs/layouts/_default/content.htmldocs/layouts/docs/baseof.htmldocs/layouts/partials/article-label.htmldocs/layouts/partials/custom-related-content.htmldocs/layouts/partials/favicons.htmldocs/layouts/partials/footer.htmldocs/layouts/partials/gtm-body.htmldocs/layouts/partials/gtm.htmldocs/layouts/partials/head-css.htmldocs/layouts/partials/head.htmldocs/layouts/partials/header-menu.htmldocs/layouts/partials/hooks/body-end.htmldocs/layouts/partials/hooks/head-end.htmldocs/layouts/partials/navbar.htmldocs/layouts/partials/prev-next-pages.htmldocs/layouts/partials/share-dialog.htmldocs/layouts/partials/toc.htmldocs/layouts/shortcodes/alert.htmldocs/layouts/shortcodes/blocks/card.htmldocs/layouts/shortcodes/blocks/cards-container.htmldocs/layouts/shortcodes/blocks/feature.htmldocs/layouts/shortcodes/blocks/homepage-hosted.htmldocs/layouts/shortcodes/blocks/homepage-learn.htmldocs/layouts/shortcodes/blocks/homepage-slack.htmldocs/layouts/shortcodes/blocks/section.htmldocs/layouts/shortcodes/blocks/sections-list.htmldocs/layouts/shortcodes/code-lang.htmldocs/layouts/shortcodes/code-select.htmldocs/layouts/shortcodes/content-block.htmldocs/layouts/shortcodes/content-select.htmldocs/layouts/shortcodes/inline-icon.htmldocs/layouts/shortcodes/label.htmldocs/layouts/shortcodes/latest-doc-dirpath.htmldocs/layouts/shortcodes/latesttag.htmldocs/layouts/shortcodes/product.htmldocs/layouts/shortcodes/swaggerui.htmldocs/layouts/swagger/baseof.htmldocs/static/js/pactsafe.jsdocs/static/js/prism.jsdocs/static/js/share.jsdocs/static/js/tables.js
💤 Files with no reviewable changes (65)
- docs/layouts/shortcodes/blocks/feature.html
- docs/layouts/partials/gtm-body.html
- docs/assets/scss/prev-next-pages.scss
- docs/layouts/404.html
- docs/layouts/shortcodes/product.html
- docs/assets/scss/tooltip.scss
- docs/layouts/shortcodes/blocks/homepage-hosted.html
- docs/layouts/partials/gtm.html
- docs/assets/scss/typography.scss
- docs/assets/scss/variables/_variables.media-queries.scss
- docs/assets/json/offline-search-index.json
- docs/layouts/_default/_markup/render-image.html
- docs/layouts/shortcodes/alert.html
- docs/layouts/shortcodes/blocks/cards-container.html
- docs/layouts/_default/baseof.html
- docs/layouts/partials/custom-related-content.html
- docs/layouts/shortcodes/content-select.html
- docs/layouts/shortcodes/code-lang.html
- docs/layouts/shortcodes/blocks/homepage-learn.html
- docs/layouts/shortcodes/code-select.html
- docs/layouts/shortcodes/inline-icon.html
- docs/assets/scss/toc.scss
- docs/layouts/partials/article-label.html
- docs/layouts/partials/favicons.html
- docs/layouts/shortcodes/blocks/section.html
- docs/layouts/shortcodes/blocks/homepage-slack.html
- docs/layouts/shortcodes/label.html
- docs/assets/scss/alert.scss
- docs/assets/scss/content-select.scss
- docs/layouts/shortcodes/blocks/card.html
- docs/static/js/tables.js
- docs/layouts/docs/baseof.html
- docs/assets/scss/header.scss
- docs/layouts/shortcodes/latesttag.html
- docs/layouts/partials/head.html
- docs/layouts/shortcodes/blocks/sections-list.html
- docs/assets/scss/homepage/sections-list.scss
- docs/layouts/shortcodes/swaggerui.html
- docs/layouts/shortcodes/content-block.html
- docs/assets/scss/tables.scss
- docs/layouts/swagger/baseof.html
- docs/layouts/shortcodes/latest-doc-dirpath.html
- docs/layouts/_default/_markup/render-link.html
- docs/layouts/partials/prev-next-pages.html
- docs/layouts/partials/head-css.html
- docs/assets/scss/share-dialog.scss
- docs/assets/scss/homepage.scss
- docs/assets/scss/homepage/box.scss
- docs/static/js/share.js
- docs/assets/scss/homepage/hosted.scss
- docs/layouts/partials/toc.html
- docs/layouts/partials/footer.html
- docs/layouts/partials/share-dialog.html
- docs/assets/scss/swagger.scss
- docs/assets/scss/homepage/slack.scss
- docs/assets/scss/homepage/icons.scss
- docs/assets/scss/homepage/learn.scss
- docs/assets/scss/functions/_functions.pxtorem.scss
- docs/assets/scss/variables/_variables.footer.scss
- docs/static/js/pactsafe.js
- docs/assets/scss/mixins/_mixins.media-queries.scss
- docs/static/js/prism.js
- docs/layouts/partials/header-menu.html
- docs/assets/scss/variables/_variables.scss
- docs/assets/scss/variables/_variables.colors.scss
🚧 Files skipped from review as they are similar to previous changes (6)
- .github/actions/hugo-build-versioned-action/action.yaml
- .github/workflows/netlify-deploy-v2.yaml
- docs/layouts/partials/hooks/body-end.html
- docs/config/_default/menus.toml
- docs/config/_default/config.toml
- docs/assets/scss/_styles_project.scss
Comment on lines
+213
to
+221
| &::after { | ||
| content: ""; | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| width: 20px; | ||
| background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%); | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Do not block the horizontal scrollbar.
This overlay sits above &__inner’s right edge and accepts pointer events, preventing interaction with the scrollbar underneath. Add pointer-events: none.
Proposed fix
&::after {
content: "";
position: absolute;
top: 0;
right: 0;
bottom: 0;
width: 20px;
+ pointer-events: none;
background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%);
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| &::after { | |
| content: ""; | |
| position: absolute; | |
| top: 0; | |
| right: 0; | |
| bottom: 0; | |
| width: 20px; | |
| background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%); | |
| } | |
| &::after { | |
| content: ""; | |
| position: absolute; | |
| top: 0; | |
| right: 0; | |
| bottom: 0; | |
| width: 20px; | |
| pointer-events: none; | |
| background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%); | |
| } |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/assets/scss/_local-overrides.scss` around lines 213 - 221, Add
pointer-events: none to the &::after overlay inside &__inner so the right-edge
gradient does not intercept horizontal scrollbar interaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit