Skip to content

impl(bigtable): export grpc metrics#16241

Draft
scotthart wants to merge 23 commits into
googleapis:mainfrom
scotthart:bigtable_grpc_metrics
Draft

impl(bigtable): export grpc metrics#16241
scotthart wants to merge 23 commits into
googleapis:mainfrom
scotthart:bigtable_grpc_metrics

Conversation

@scotthart

Copy link
Copy Markdown
Member

No description provided.

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Jul 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a GrpcMetricsExporter to export gRPC OpenTelemetry metrics for Google Cloud Bigtable, integrating it into the DataConnectionImpl and adding corresponding build configurations and unit tests. The review feedback highlights several key improvements: enforcing the singleton pattern for GrpcMetricsExporterRegistry by making its constructor private, optimizing latency boundary generation via static caching, removing an unused default parameter in an internal namespace lambda to align with the style guide, and resolving a potential use-after-move/evaluation-order issue when constructing MonitoredResourceResult.

Comment thread google/cloud/bigtable/internal/grpc_metrics_exporter.h
Comment thread google/cloud/bigtable/internal/grpc_metrics_exporter.cc
Comment thread google/cloud/bigtable/internal/grpc_metrics_exporter.cc Outdated
Comment thread google/cloud/bigtable/internal/grpc_metrics_exporter.cc Outdated
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.35211% with 140 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.23%. Comparing base (0ba8e5f) to head (017e70a).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...d/bigtable/tests/observability_integration_test.cc 12.58% 125 Missing ⚠️
...e/cloud/bigtable/internal/grpc_metrics_exporter.cc 93.58% 10 Missing ⚠️
...d/bigtable/testing/embedded_server_test_fixture.cc 0.00% 3 Missing ⚠️
...ud/bigtable/internal/grpc_metrics_exporter_test.cc 99.10% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16241      +/-   ##
==========================================
- Coverage   92.29%   92.23%   -0.07%     
==========================================
  Files        2221     2225       +4     
  Lines      207373   207960     +587     
==========================================
+ Hits       191391   191804     +413     
- Misses      15982    16156     +174     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant