impl(bigtable): export grpc metrics#16241
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a GrpcMetricsExporter to export gRPC OpenTelemetry metrics for Google Cloud Bigtable, integrating it into the DataConnectionImpl and adding corresponding build configurations and unit tests. The review feedback highlights several key improvements: enforcing the singleton pattern for GrpcMetricsExporterRegistry by making its constructor private, optimizing latency boundary generation via static caching, removing an unused default parameter in an internal namespace lambda to align with the style guide, and resolving a potential use-after-move/evaluation-order issue when constructing MonitoredResourceResult.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16241 +/- ##
==========================================
- Coverage 92.29% 92.23% -0.07%
==========================================
Files 2221 2225 +4
Lines 207373 207960 +587
==========================================
+ Hits 191391 191804 +413
- Misses 15982 16156 +174 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3ad3d37 to
a83c1ee
Compare
c9f7c9f to
831c198
Compare
No description provided.