Test memory limits for composition worker - #8247
Open
jdolle wants to merge 4 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Contributor
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Our composition worker has a strict memory limit. This test is a regression to ensure we don't make changes that exceed the memory limit without knowing it.
Description
I did manual testing to determine that the memory usage is roughly a multiplier of the schema size.
The test generates a schema given a size requirement, and creates a worker based on a multiplier of that schema size.
This adds two checks, both with the same schema size, but with different multipliers. One passes because it's 150x the schema size (5mb schema -> 750mb worker), and the other check errors because the worker is 735mb.
The 150x multiplier is surprising. It seems very high. But based on testing it seems accurate.