Add x-ray tracing to tag-page-rendering - #16453
Draft
jorgeazevedo wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This implements request tracing in tag-page-rendering. There quite a number of technical aspects to review, but broadly the idea is
new OpenTelemetryWebpackPluginat build time ?)Jaeger screenshot

X-ray screenshot (see it in AWS)
Architecture
OTEL (OpenTelemetry)
While there is an AWS X-ray SDK to post traces directly to the service, I believe it's been deprecated in favour of using OTEL. OTEL Is also a good match as it decouples the collection of traces from the services they end up in. The application posts the traces to http://localhost:4318, which in AWS is an x-ray sidecar that forwards them to x-ray, but locally is a Jaeger container that stores the data and makes available via a web UI.
Auto instrumentation
TODO: how we inject the javascript. And how auto instrumentation doesn't support webpack, so this PR uses a community plugin to get it to work
Jaeger
Jaeger is an open-source tracing platform. We use the official container
X-ray
TODO: The implementation is based on the official AWS otel collector container. I found documentation to be quite sparse, so I had copilot help write it and set it up with a default configuration file that's bundled with the container and does what we want, but I'm not super familiar with this aspect of it yet. The end result is similar to the one in this aws page.
Why?
How has this change been tested?
Screenshots