feat(open): prefer OAuth alias URLs#68
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3f832636b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
open.preferand one-shothack open --prefer <auto|alias|dev>controlshack branch openWhy
Projects that enable OAuth need browser-facing
.hack.gyaliases for callbacks and shared cookie domains, whiledev_hostshould remain the stable primary routing identity. Previouslyhack openalways returned the primary.hackhost, forcing applications and agents to reconstruct or redirect to the alias themselves.User impact
With the default
open.prefer: auto,hack opennow opens the alias wheneveroauth.enabledis true and falls back to the dev host otherwise. Users can pin either behavior in project config or override one invocation. Container-to-container traffic remains on Compose DNS.Validation
bun run checkbunx tsc -p packages/cli/tsconfig.json --noEmitbun run buildbun tests/e2e/run.ts --only=worktree-branch-defaultpsEPERM indaemon-command.test.tspsRelease signal
Feature change; publish as a minor release.