Proper NetworkCurl lifetime management#1716
Merged
andrey-kashcheev merged 9 commits intoJul 23, 2026
Merged
Conversation
added 5 commits
July 22, 2026 11:21
The NetworkCurl is made safe against being destroyed from its own callbacks (header, data, completion). The following was made: - RequestHandle no longer holds the NetworkCurl, it holds the actual necessary shared data instead - a part of NetworkCurl is extracted to internal Impl class encapsulating everything needed for internal worker thread; such way that thread does not need any reference to NetworkCurl - the worker thread holds a strong reference to the Impl instance, so it won't get destroyed until the worker thread completes - all the resources are cleaned up regardless of the way the worker thread exits (either via join or via detach) Relates-To: OCMAM-772 Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
exposight
force-pushed
the
network-curl-proper-ownership
branch
from
July 22, 2026 08:21
ebd091f to
dfec753
Compare
added 3 commits
July 22, 2026 11:48
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
exposight
force-pushed
the
network-curl-proper-ownership
branch
3 times, most recently
from
July 22, 2026 09:11
a034ee8 to
9a78492
Compare
To fix the build without exceptions. Relates-To: HERESDK-4984, OCMAM-772 Signed-off-by: Vasyl Bilous <ext-vasyl.bilous@here.com>
exposight
force-pushed
the
network-curl-proper-ownership
branch
from
July 22, 2026 11:03
9a78492 to
7f8d2ca
Compare
andrey-kashcheev
approved these changes
Jul 23, 2026
mykolamalik
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NetworkCurlis made safe against being destroyed from its own callbacks (header, data, completion). The following was made:RequestHandleno longer holds theNetworkCurl, it holds the actual necessary shared data insteadNetworkCurlis extracted to internalImplclass encapsulating everything needed for internal worker thread; such way that thread does not need any reference toNetworkCurland in turn the thread won't own itselfImplinstance, so it won't get destroyed until the worker thread completesRelates-To: HERESDK-4984, OCMAM-772