Fix: initialize dep-gen before orchestrator submission#1454
Conversation
Initialize the dep-gen buffer in the leader pre-handshake path before hs_setup_done_ releases the decoupled orchestrator. This prevents early task submissions from being silently skipped while scheduler threads are still handshaking. Keep PMU and dump initialization post-handshake, and run the a2a3/a5 dep-gen smoke with the full worker count so task zero remains covered under the wider handshake window.
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Drive-by data point: this race also fires onboard on a2a3, not just in the sim smokes.
Run: https://github.com/hw-native-sys/simpler/actions/runs/30184309146/job/89746344476 Confirmed intermittent: a plain re-run of the same job on the same commit passed, and the same test passed 3/3 locally on a2a3 silicon under CI-equivalent flags ( No action needed here — just noting that the onboard job is an additional (flaky) surface for the same bug, so this fix should quiet it too. |
Summary
pre_handshake_init, before the decoupled orchestrator can submit task 0Root cause
The barrier-free scheduler initialization lets the orchestrator build the graph while scheduler threads are still handshaking. Dep-gen initialization was left in the post-handshake profiling path, so early
dep_gen_aicpu_record_submitcalls saw a null collector state and returned without recording the leading tasks or their dependencies.Testing
1 passed)1 passed)2 passed)2 passed)