mesh: unhide service settings documentation#3743
Conversation
Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @dlanov! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @dlanov. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Unhide
MeshConfig.ServiceSettingsand theservice_settingsfield so they appear in the generated MeshConfig API reference.This removes the two
$hide_from_docsmarkers and regenerates the corresponding Go and HTML outputs. It does not change the API or runtime behavior.Fixes istio/istio#54762
Validation:
make genmake local-lint-protosmake testgit diff --check