Skip to content

mesh: unhide service settings documentation#3743

Open
dlanov wants to merge 1 commit into
istio:masterfrom
dlanov:docs-unhide-meshconfig-service-settings
Open

mesh: unhide service settings documentation#3743
dlanov wants to merge 1 commit into
istio:masterfrom
dlanov:docs-unhide-meshconfig-service-settings

Conversation

@dlanov

@dlanov dlanov commented Jul 17, 2026

Copy link
Copy Markdown

Unhide MeshConfig.ServiceSettings and the service_settings field so they appear in the generated MeshConfig API reference.

This removes the two $hide_from_docs markers and regenerates the corresponding Go and HTML outputs. It does not change the API or runtime behavior.

Fixes istio/istio#54762

Validation:

  • make gen
  • make local-lint-protos
  • make test
  • git diff --check

Signed-off-by: Dennis Lanov <dennis.lanov@gmail.com>
@dlanov
dlanov requested a review from a team as a code owner July 17, 2026 13:42
@istio-policy-bot

Copy link
Copy Markdown

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @dlanov! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @dlanov. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MeshConfig documentation is missing the serviceSettings setting

3 participants