Fix rcr indexing - #2
Open
DanRyanIrish wants to merge 9 commits into
Open
Conversation
* Automatic package template update * Fix conflicts Co-authored-by: Shane Maloney <shane.maloney@dias.ie>
* Render Change log for v0.3.0 * Add citation file, update mailmap and zenodo
Co-authored-by: samaloney <24570854+samaloney@users.noreply.github.com>
* Add submodule task to doc job * Ok one more time
….com/jajmitchell/stixpy into jajmitchell/adds_livetime_correction_to_get_data
Author
|
Don't know why the diff is so huge. When I diff it locally, I only see changes in science.py... |
Author
|
Perhaps you can just cherry-pick the this commit: 589ed1f |
jajmitchell
reviewed
Jul 29, 2026
|
|
||
| # An SRM can only be calculated if the attenutator does not move. | ||
| # Therefore ensure that rcr_unique is an int. | ||
| if len(rcr_unique) > 2: |
Owner
There was a problem hiding this comment.
for spec 1D cases, len(rcr_unique) must be 1, however for spec_sequence cases rcr_unique can be any length up to 7, we just then need to create an srm for each rcr state and ensure its added to the correct metadata
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.