Skip to content

refactor: improve Makefile variables used to build artifact names, remove unused cmd line argument when building binary wheel artifacts #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenstroeger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: improve Makefile variables used to build artifact names, remove unused cmd line argument when building binary wheel artifacts #1254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ PACKAGE_VERSION := $(shell python -c $$'try: import $(PACKAGE_NAME); print($(PAC
# (py3), the ABI tag (none), and the platform tag (any) for the final wheel
# file name.
PACKAGE_BASE_NAME := $(PACKAGE_NAME)-$(PACKAGE_VERSION)
PACKAGE_SDIST_NAME := $(PACKAGE_BASE_NAME).tar.gz
PACKAGE_WHEEL_NAME := $(PACKAGE_BASE_NAME)-py3-none-any.whl
PACKAGE_SDIST_BASE_NAME := $(PACKAGE_BASE_NAME)
PACKAGE_SDIST_NAME := $(PACKAGE_SDIST_BASE_NAME).tar.gz
PACKAGE_WHEEL_BASE_NAME := $(PACKAGE_BASE_NAME)-py3-none-any
PACKAGE_WHEEL_NAME := $(PACKAGE_WHEEL_BASE_NAME).whl

# If a PYTHON environment variable exists then use that, else define it here.
PYTHON ?= python3.14
Expand Down Expand Up @@ -194,8 +196,8 @@ test-all: test-unit test-integration test-performance
.PHONY: dist
dist: dist/$(PACKAGE_WHEEL_NAME) dist/$(PACKAGE_SDIST_NAME) dist/$(PACKAGE_BASE_NAME)-docs-html.zip dist/$(PACKAGE_BASE_NAME)-docs-md.zip
dist/$(PACKAGE_WHEEL_NAME): check test-all
SOURCE_DATE_EPOCH=$(SOURCE_DATE_EPOCH) python -m flit build --setup-py --format wheel
echo $(SOURCE_DATE_EPOCH) > dist/$(PACKAGE_BASE_NAME)-py3-none-any-build-epoch.txt
SOURCE_DATE_EPOCH=$(SOURCE_DATE_EPOCH) python -m flit build --format wheel
echo $(SOURCE_DATE_EPOCH) > dist/$(PACKAGE_WHEEL_BASE_NAME)-build-epoch.txt
dist/$(PACKAGE_SDIST_NAME): check test-all
SOURCE_DATE_EPOCH=$(SOURCE_DATE_EPOCH) python -m flit build --no-setup-py --format sdist
dist/$(PACKAGE_BASE_NAME)-docs-html.zip: docs-html
Expand Down
Loading