Skip to content

fix: make sure to call the pre-commit from the local venv instead of possibly sneaking in one from the PATH #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenstroeger wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix: make sure to call the pre-commit from the local venv instead of possibly sneaking in one from the PATH #1255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ venv:
# See https://packaging.python.org/en/latest/tutorials/packaging-projects/#generating-distribution-archives.
.PHONY: setup
setup: force-upgrade
pre-commit install
python -m pre_commit install
mkdir -p dist

# Install or upgrade an existing virtual environment based on the
Expand Down Expand Up @@ -165,15 +165,15 @@ audit:
.PHONY: check check-code check-ruff check-lint check-mypy check-actionlint
check-code: check-ruff check-lint check-mypy check-actionlint
check-ruff:
pre-commit run ruff --all-files
python -m pre_commit run ruff --all-files
check-lint:
pre-commit run pylint --all-files
python -m pre_commit run pylint --all-files
check-mypy:
pre-commit run mypy --all-files
python -m pre_commit run mypy --all-files
check-actionlint:
pre-commit run actionlint --all-files
python -m pre_commit run actionlint --all-files
check:
pre-commit run --all-files
python -m pre_commit run --all-files

# Run different kinds of tests: unit tests, integration tests, performance tests.
# Note that the default goal 'test' runs the unit tests only, mainly for convenience
Expand Down
Loading