Skip to content

refactor: remove dead code and rename ReturnType #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kakasoo merged 1 commit into from
Feb 20, 2026
Merged

refactor: remove dead code and rename ReturnType #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/functions/DeepStrictObjectKeys.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type Replace<S extends string> = S extends '[*]'
/** @internal Removes glob patterns (e.g., `'*'`, `'a.*'`) from a string union. */
type WithoutGlob<K extends string> = K extends '*' | `${string}.*` ? never : K;

type ReturnType<
type DeepStrictObjectKeysResult<
Target extends object,
Joiner extends { array: string; object: string } = { array: '[*]'; object: '.' },
> = [Target] extends [never]
Expand Down Expand Up @@ -52,12 +52,7 @@ type ReturnType<
export function deepStrictObjectKeys<
Target extends object,
Joiner extends { array: string; object: string } = { array: '[*]'; object: '.' },
>(target: Target): ReturnType<Target, Joiner> {
let joiner: Joiner = { array: '[*]', object: '.' } as Joiner;
if (joiner === undefined) {
joiner = { array: '[*]', object: '.' } as Joiner;
}

>(target: Target): DeepStrictObjectKeysResult<Target, Joiner> {
const response = [];
const keys = Object.keys(target);
response.push(...keys);
Expand All @@ -72,5 +67,5 @@ export function deepStrictObjectKeys<
}
}

return Array.from(new Set(response)) as ReturnType<Target, Joiner>;
return Array.from(new Set(response)) as DeepStrictObjectKeysResult<Target, Joiner>;
}