Recover Docker before macOS tests#308
Merged
Merged
Conversation
42d6a88 to
2c37c48
Compare
sjmiller609
reviewed
Jul 15, 2026
sjmiller609
left a comment
Collaborator
There was a problem hiding this comment.
thanks, this is very helpful but just one thing
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e36e29d. Configure here.
sjmiller609
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

summary
why
The self-hosted macOS runner can retain a stopped or broken Colima VM between jobs. The prewarm step requires Docker to start its local registry, so the job currently fails before running tests when that daemon is unavailable.
validation
.github/workflows/test.ymlas YAMLbash -ngit diff --checktest-darwinpassed end to end, including normal startup, stale-state recovery, prewarm, formatting, and testsNote
Low Risk
CI-only workflow change on macOS runners; no application, auth, or data-path impact.
Overview
Adds an Ensure Docker is running step at the start of the
test-darwinjob so a stopped or broken Colima VM on the self-hosted macOS runner does not fail the job before prewarm (which needs Docker for the local registry).The step exits early if
docker infosucceeds; otherwise it triescolima start, escalates to force-stop/restart and thencolima deleteif needed, and polls up to ~60s for the daemon before failing withdocker info.Reviewed by Cursor Bugbot for commit ce45c8a. Bugbot is set up for automated code reviews on this repo. Configure here.