Skip to content

Recover Docker before macOS tests#308

Merged
IlyaasK merged 3 commits into
mainfrom
hypeship/repair-darwin-docker
Jul 15, 2026
Merged

Recover Docker before macOS tests#308
IlyaasK merged 3 commits into
mainfrom
hypeship/repair-darwin-docker

Conversation

@IlyaasK

@IlyaasK IlyaasK commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

summary

  • verify the Docker daemon before the macOS test job uses it
  • start Colima directly when it is stopped
  • force-restart Colima only when Docker is unhealthy or a normal start fails
  • recreate the Colima VM if recovery still fails
  • wait up to 60 seconds for the daemon to become ready before continuing

why

The self-hosted macOS runner can retain a stopped or broken Colima VM between jobs. The prewarm step requires Docker to start its local registry, so the job currently fails before running tests when that daemon is unavailable.

validation

  • parsed .github/workflows/test.yml as YAML
  • checked the recovery script with bash -n
  • git diff --check
  • test-darwin passed end to end, including normal startup, stale-state recovery, prewarm, formatting, and tests

Note

Low Risk
CI-only workflow change on macOS runners; no application, auth, or data-path impact.

Overview
Adds an Ensure Docker is running step at the start of the test-darwin job so a stopped or broken Colima VM on the self-hosted macOS runner does not fail the job before prewarm (which needs Docker for the local registry).

The step exits early if docker info succeeds; otherwise it tries colima start, escalates to force-stop/restart and then colima delete if needed, and polls up to ~60s for the daemon before failing with docker info.

Reviewed by Cursor Bugbot for commit ce45c8a. Bugbot is set up for automated code reviews on this repo. Configure here.

@IlyaasK IlyaasK force-pushed the hypeship/repair-darwin-docker branch from 42d6a88 to 2c37c48 Compare July 15, 2026 19:09
@IlyaasK IlyaasK marked this pull request as ready for review July 15, 2026 19:12
@IlyaasK IlyaasK requested a review from sjmiller609 July 15, 2026 19:12
Comment thread .github/workflows/test.yml Outdated
@IlyaasK IlyaasK requested a review from hiroTamada July 15, 2026 19:15

@sjmiller609 sjmiller609 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is very helpful but just one thing

Comment thread .github/workflows/test.yml Outdated
@IlyaasK IlyaasK requested a review from sjmiller609 July 15, 2026 19:28

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e36e29d. Configure here.

Comment thread .github/workflows/test.yml
@IlyaasK IlyaasK merged commit dfe496f into main Jul 15, 2026
11 checks passed
@IlyaasK IlyaasK deleted the hypeship/repair-darwin-docker branch July 15, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants