Upgrade Ansible 12.3.0#13282
Open
tico88612 wants to merge 8 commits into
Open
Conversation
k8s-ci-robot
added
release-note
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tico88612 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
approved
Member
Author
|
/label tide/merge-method-merge |
k8s-ci-robot
added
the
tide/merge-method-merge
k8s-ci-robot
added
the
do-not-merge/work-in-progress
tico88612
force-pushed
the
feat/ansible-12
branch
from
0e4f8ed to
d59dfd6
Compare
k8s-ci-robot
added
size/M
tico88612
force-pushed
the
feat/ansible-12
branch
2 times, most recently
from
b24edee to
9072108
Compare
k8s-ci-robot
added
size/S
tico88612
force-pushed
the
feat/ansible-12
branch
2 times, most recently
from
86051ce to
e819c6a
Compare
k8s-ci-robot
added
size/M
tico88612
force-pushed
the
feat/ansible-12
branch
from
f6d43ac to
80e65b3
Compare
tico88612
force-pushed
the
feat/ansible-12
branch
from
80e65b3 to
4a7b108
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
Member
Author
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
needs-rebase
There was a problem hiding this comment.
Pull request overview
This PR upgrades Kubespray’s Ansible dependency from 11.x to 12.3.0 (and updates the supported ansible-core range accordingly), with a handful of playbook/template adjustments to stay compatible with ansible-core 2.19 behavior.
Changes:
- Bump
ansibleto12.3.0and update the supportedansible-corerange to>=2.19.0,<2.20.0across runtime checks, docs, and pre-commit. - Refactor several Calico resources from hand-built JSON strings to native YAML dicts serialized via
to_json. - Refactor etcd OpenSSL SAN generation and cert slurp item lists for cleaner templating.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ansible.cfg | Enables allow_broken_conditionals for test runs under ansible-core 2.19+. |
| roles/system_packages/tasks/main.yml | Removes Fedora-specific raw dnf workaround that was gated on older ansible-core behavior. |
| roles/network_plugin/calico/tasks/install.yml | Refactors Felix/IPPool/BGP config generation to YAML structures + to_json. |
| roles/kubespray_defaults/defaults/main/main.yml | Simplifies ssl_ca_dirs default selection logic using a dict lookup. |
| roles/kubespray_defaults/defaults/main/download.yml | Changes file modes to quoted strings (e.g., "0755") for YAML correctness. |
| roles/etcd/templates/openssl.conf.j2 | Reworks SAN generation to accumulate DNS/IP lists and render with loop indices. |
| roles/etcd/tasks/gen_certs_script.yml | Replaces stringified list construction with explicit list concatenation. |
| requirements.txt | Pins Ansible to 12.3.0. |
| playbooks/ansible_version.yml | Updates version guard to 2.19.0 <= ansible-core < 2.20.0. |
| meta/runtime.yml | Updates collection runtime requirement to >=2.19.0,<2.20.0. |
| docs/ansible/ansible.md | Updates the documented supported Ansible/ansible-core range. |
| ansible.cfg | Enables allow_broken_conditionals globally for users/runs. |
| .pre-commit-config.yaml | Updates hook dependencies to ansible-core>=2.19.0,<2.20.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+325
to
+329
| set_fact: | ||
| _bgp_config: "{{ _bgp_config | combine({'spec': {'serviceClusterIPs': [{'cidr': _cluster_ip_cidr}]}}, recursive=True) }}" | ||
| vars: | ||
| _cluster_ip_cidr: "{{ kube_service_addresses_ipv6 if ipv6_stack | bool else kube_service_addresses }}" | ||
| when: calico_advertise_cluster_ips | default(false) |
Comment on lines
+22
to
+23
| # TODO: Review our conditions, and set this to false. | ||
| allow_broken_conditionals=True |
Comment on lines
+17
to
+18
| # TODO: Review our conditions, and set this to false. | ||
| allow_broken_conditionals=True |
tico88612
force-pushed
the
feat/ansible-12
branch
from
4a7b108 to
2bfa4a7
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tico88612 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
removed
the
needs-rebase
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
…ted string Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
…ne Jinja loops Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
…ative Jinja Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
…rings Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
tico88612
force-pushed
the
feat/ansible-12
branch
from
2bfa4a7 to
3bfd3d0
Compare
kubernetes-prow
Bot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Ansible 11.x was EOL. Let's upgrade this.
Special notes for your reviewer:
The support matrix does not change between 11 and 12; maybe we can safely upgrade this.
I used AI to fix and upgrade Ansible 12.
Does this PR introduce a user-facing change?: