cilium: render routingMode: native when cilium_tunnel_mode is disabled#13314
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
Welcome @sinashahoveisi! |
|
Hi @sinashahoveisi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sinashahoveisi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
When cilium_tunnel_mode is set to disabled, the previous template rendered tunnelProtocol: disabled in the Helm values. Cilium does not recognize this value and falls back to vxlan, which directly conflicts with routingMode: native and causes agents to CrashLoopBackOff. Fix the values.yaml.j2 template to emit routingMode: native when cilium_tunnel_mode is disabled, matching the Cilium Helm chart API. Update the variable comment in defaults/main.yml to document this behavior. Related to issue 13267
c648733 to
bdd56a6
Compare
|
@sinashahoveisi could you checkout your CLA and release-note? |
|
Hi @tico88612, thank you for the review! Unfortunately, as a contributor based in Iran, I am unable to sign the CLA due to OFAC compliance restrictions. I understand this is a blocker for merging. Regarding the release-note, I will add it now. |
|
/ok-to-test |
There was a problem hiding this comment.
Pull request overview
This PR fixes Cilium Helm values rendering when cilium_tunnel_mode: disabled is configured, ensuring Kubespray emits the correct Cilium chart setting (routingMode: native) instead of an unsupported tunnelProtocol: disabled value that can lead to agent CrashLoopBackOff.
Changes:
- Render
routingMode: nativewhencilium_tunnel_modeis set todisabled(otherwise keep renderingtunnelProtocol). - Clarify
cilium_tunnel_modesemantics in role defaults, including thedisabledbehavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roles/network_plugin/cilium/templates/values.yaml.j2 | Adds conditional rendering to output routingMode: native when tunneling is disabled, aligning with the Cilium Helm chart API. |
| roles/network_plugin/cilium/defaults/main.yml | Updates comments to document valid tunnel mode values and explain the rendered Helm values behavior for disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What type of PR is this?
/kind bug
What this PR does / why we need it
When
cilium_tunnel_mode: disabledis set in inventory, the previoustemplate rendered
tunnelProtocol: disabledin the Helm values.Cilium does not recognize this value and falls back to
vxlan, whichdirectly conflicts with
routingMode: nativeand causes agents toCrashLoopBackOff.
The fix renders
routingMode: nativeinstead whencilium_tunnel_modeis
disabled, matching the Cilium Helm chart API.Which issue(s) this PR fixes
Related to issue 13267
Does this PR introduce a user-facing change?
Users no longer need to manually inject
tunnelProtocol: ""viacilium_extra_values. Settingcilium_tunnel_mode: disablednowworks as documented in defaults/main.yml.