Skip to content

cilium: render routingMode: native when cilium_tunnel_mode is disabled#13314

Open
sinashahoveisi wants to merge 1 commit into
kubernetes-sigs:masterfrom
sinashahoveisi:fix/cilium-tunnel-disabled-native-routing-13267
Open

cilium: render routingMode: native when cilium_tunnel_mode is disabled#13314
sinashahoveisi wants to merge 1 commit into
kubernetes-sigs:masterfrom
sinashahoveisi:fix/cilium-tunnel-disabled-native-routing-13267

Conversation

@sinashahoveisi

@sinashahoveisi sinashahoveisi commented Jun 18, 2026

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it

When cilium_tunnel_mode: disabled is set in inventory, the previous
template rendered tunnelProtocol: disabled in the Helm values.
Cilium does not recognize this value and falls back to vxlan, which
directly conflicts with routingMode: native and causes agents to
CrashLoopBackOff.

The fix renders routingMode: native instead when cilium_tunnel_mode
is disabled, matching the Cilium Helm chart API.

Which issue(s) this PR fixes

Related to issue 13267

Does this PR introduce a user-facing change?

Users no longer need to manually inject tunnelProtocol: "" via
cilium_extra_values. Setting cilium_tunnel_mode: disabled now
works as documented in defaults/main.yml.

Fix Cilium CrashLoopBackOff when cilium_tunnel_mode is set to disabled
by rendering routingMode: native instead of tunnelProtocol: disabled
in the Helm values.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 18, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 18, 2026

Copy link
Copy Markdown

CLA Not Signed

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @sinashahoveisi!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @sinashahoveisi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 18, 2026
@k8s-ci-robot k8s-ci-robot requested review from guoard and mzaian June 18, 2026 17:09
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sinashahoveisi
Once this PR has been reviewed and has the lgtm label, please assign tico88612 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

When cilium_tunnel_mode is set to disabled, the previous template
rendered tunnelProtocol: disabled in the Helm values. Cilium does not
recognize this value and falls back to vxlan, which directly conflicts
with routingMode: native and causes agents to CrashLoopBackOff.

Fix the values.yaml.j2 template to emit routingMode: native when
cilium_tunnel_mode is disabled, matching the Cilium Helm chart API.
Update the variable comment in defaults/main.yml to document this
behavior.

Related to issue 13267
@sinashahoveisi sinashahoveisi force-pushed the fix/cilium-tunnel-disabled-native-routing-13267 branch from c648733 to bdd56a6 Compare June 18, 2026 17:14
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 18, 2026
@tico88612

Copy link
Copy Markdown
Member

@sinashahoveisi could you checkout your CLA and release-note?

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 21, 2026
@sinashahoveisi

Copy link
Copy Markdown
Author

Hi @tico88612, thank you for the review!

Unfortunately, as a contributor based in Iran, I am unable to sign the CLA due to OFAC compliance restrictions. I understand this is a blocker for merging.

Regarding the release-note, I will add it now.

@yankay

yankay commented Jun 24, 2026

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 24, 2026
@yankay yankay requested a review from Copilot June 24, 2026 11:27
@kubernetes-prow kubernetes-prow Bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Cilium Helm values rendering when cilium_tunnel_mode: disabled is configured, ensuring Kubespray emits the correct Cilium chart setting (routingMode: native) instead of an unsupported tunnelProtocol: disabled value that can lead to agent CrashLoopBackOff.

Changes:

  • Render routingMode: native when cilium_tunnel_mode is set to disabled (otherwise keep rendering tunnelProtocol).
  • Clarify cilium_tunnel_mode semantics in role defaults, including the disabled behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
roles/network_plugin/cilium/templates/values.yaml.j2 Adds conditional rendering to output routingMode: native when tunneling is disabled, aligning with the Cilium Helm chart API.
roles/network_plugin/cilium/defaults/main.yml Updates comments to document valid tunnel mode values and explain the rendered Helm values behavior for disabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants