Replace injected Ansible fact variables in network_facts and system_packages role by wt · Pull Request #13324 · kubernetes-sigs/kubespray

wt · 2026-06-23T07:12:48Z

The old way of injecting facts as variables is deprecated. Switching to the new way.

roles updated:

network_facts
system_packages

/kind bug

Special notes for your reviewer:
Injecting facts as vars is deprecated. See here.

Just so you know, I am using a local branch modified to allow the use of ansible 2.20. These changes should be backward compatible with 2.18/19, which are the currently supported versions of ansible for kubespray.

Does this PR introduce a user-facing change?

NONE

kubernetes-prow · 2026-06-23T07:12:59Z

Hi @wt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tico88612 · 2026-06-23T08:08:55Z

Related #13208

/ok-to-test

tico88612 · 2026-06-23T08:09:08Z

/remove-kind bug
/kind cleanup

tico88612 · 2026-06-23T08:48:19Z

/retitle Replace injected Ansible fact variables in network_facts and system_packages role

wt · 2026-06-24T07:19:59Z

Assuming the tests all pass. I think this one is ready to go.

Copilot

Pull request overview

This PR updates Kubespray’s network_facts and system_packages roles to avoid deprecated “inject facts as vars” usage by switching from injected ansible_* fact variables (e.g., ansible_os_family) to ansible_facts[...] access, in line with Ansible’s porting guidance.

Changes:

Replace injected OS/distribution/package-manager fact variables with ansible_facts[...] in system_packages.
Update network_facts to gather and reference network facts via ansible_facts instead of injected ansible_default_* variables.
Adjust network_facts hostname extraction logic for no_proxy preparation (currently has a functional regression).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
roles/system_packages/vars/main.yml	Switch package condition predicates from injected fact vars to `ansible_facts[...]`.
roles/system_packages/tasks/main.yml	Use `ansible_facts[...]` for pkg manager / OS checks and package cache behavior.
roles/network_facts/tasks/main.yaml	Use `ansible_facts` for default IP facts and update fact-gathering filter; modifies no_proxy hostname aggregation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

wt · 2026-06-26T19:22:14Z

I have converted this back to a draft to experiment with just enabling the inject_facts_as_vars = no in the test config. I want to see how much fallout that causes.

The old way of injecting facts as variables is deprecated. Switching to the new way. roles updated: * network_facts * system_packages

wt · 2026-06-28T23:09:09Z

Can someone please check this one to see if it's ready for lgtm/approve?

tico88612

one more question, but nit.

otherwise LGTM

tico88612 · 2026-07-14T02:54:53Z

-    filter: "ansible_default_ip*"
-  when: ansible_default_ipv4 is not defined or ansible_default_ipv6 is not defined
+    filter: "default_ip*"
+  when: "ansible_facts is not defined or 'default_ipv4' not in ansible_facts or 'default_ipv6' not in ansible_facts"


Do we need ansible_facts is not defined here?
Under what circumstances would ansible_facts be undefined?

kubernetes-prow Bot requested review from VannTen and mzaian June 23, 2026 07:12

kubernetes-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 23, 2026

kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 23, 2026

kubernetes-prow Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jun 23, 2026

VannTen reviewed Jun 23, 2026

View reviewed changes

Comment thread roles/network_facts/tasks/main.yaml Outdated

kubernetes-prow Bot changed the title ~~fix: access facts in supported manner~~ Replace injected Ansible fact variables in network_facts and system_packages role Jun 23, 2026

wt force-pushed the fix_ansible_2.20_fact_inject_warnings branch 4 times, most recently from 72d1e42 to 7a10466 Compare June 23, 2026 10:01

wt force-pushed the fix_ansible_2.20_fact_inject_warnings branch from 69bd0c4 to 541bc70 Compare June 23, 2026 10:39

kubernetes-prow Bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 23, 2026

wt marked this pull request as draft June 23, 2026 10:39

kubernetes-prow Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 23, 2026

kubernetes-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2026

wt force-pushed the fix_ansible_2.20_fact_inject_warnings branch from 2adceb3 to f622e71 Compare June 24, 2026 06:39

kubernetes-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2026

wt force-pushed the fix_ansible_2.20_fact_inject_warnings branch 2 times, most recently from 66efc7e to ad7c8f6 Compare June 24, 2026 07:14

wt marked this pull request as ready for review June 24, 2026 07:19

kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2026

kubernetes-prow Bot requested a review from yankay June 24, 2026 07:20

yankay requested a review from Copilot June 24, 2026 11:26

Copilot started reviewing on behalf of yankay June 24, 2026 11:26 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread roles/network_facts/tasks/main.yaml

Comment thread roles/network_facts/tasks/main.yaml

yankay requested a review from Copilot June 25, 2026 06:41

Copilot started reviewing on behalf of yankay June 25, 2026 06:41 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread roles/network_facts/tasks/main.yaml Outdated

Comment thread roles/network_facts/tasks/main.yaml Outdated

Comment thread roles/network_facts/tasks/main.yaml

wt marked this pull request as draft June 26, 2026 19:21

kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026

wt force-pushed the fix_ansible_2.20_fact_inject_warnings branch 3 times, most recently from 8c24637 to c7ec84d Compare June 26, 2026 20:18

wt marked this pull request as ready for review June 26, 2026 20:40

kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026

kubernetes-prow Bot requested a review from guoard June 26, 2026 20:40

fix: access facts in supported manner

f8fcaa9

The old way of injecting facts as variables is deprecated. Switching to the new way. roles updated: * network_facts * system_packages

tico88612 reviewed Jul 14, 2026

View reviewed changes

Uh oh!

Conversation

wt commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubernetes-prow Bot commented Jun 23, 2026

Uh oh!

tico88612 commented Jun 23, 2026

Uh oh!

tico88612 commented Jun 23, 2026

Uh oh!

Uh oh!

tico88612 commented Jun 23, 2026

Uh oh!

wt commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wt commented Jun 26, 2026

Uh oh!

wt commented Jun 28, 2026

Uh oh!

tico88612 left a comment

Choose a reason for hiding this comment

Uh oh!

tico88612 Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

wt commented Jun 23, 2026 •

edited

Loading

wt commented Jun 24, 2026 •

edited

Loading