fix(gateway-api): use server-side apply to avoid annotation size limit#13326
fix(gateway-api): use server-side apply to avoid annotation size limit#13326Lanyujiex wants to merge 1 commit into
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
added
kind/bug
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Lanyujiex The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
size/S
|
Hi @Lanyujiex. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
kubernetes-prow
Bot
added
the
cncf-cla: no
Lanyujiex
force-pushed
the
fix_experimental_crds
branch
from
85bb384 to
32fb67a
Compare
kubernetes-prow
Bot
added
cncf-cla: yes
|
/ok-to-test |
kubernetes-prow
Bot
added
ok-to-test
There was a problem hiding this comment.
Pull request overview
Switches Gateway API CRD installation to server-side apply to avoid Kubernetes’ 262144-byte annotation size limit encountered with client-side apply for experimental Gateway API v1.5.x+.
Changes:
- Replaces
kubemodule usage withkubectl apply --server-sidefor Gateway API install manifests. - Adds task result registration and a custom
changed_whento preserve idempotent reporting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --server-side=true | ||
| --force-conflicts | ||
| -f {{ kube_config_dir }}/addons/gateway_api/{{ gateway_api_channel }}-install.yaml |
Lanyujiex
force-pushed
the
fix_experimental_crds
branch
from
32fb67a to
254e8c6
Compare
The Gateway API HTTPRoute CRD in experimental channel (v1.5.x+) exceeds Kubernetes' 262144-byte annotation limit when using client-side apply. Switch to server-side apply to bypass this limitation.
Lanyujiex
force-pushed
the
fix_experimental_crds
branch
from
254e8c6 to
267d642
Compare
|
This is handled in #12299 . I'd rather avoid introducing change which will need to be rebased against. |
kubernetes-prow
Bot
added
the
do-not-merge/hold
|
(not that besides that, this should use the |
|
Understood, I'll wait for #12299 to be merged and then rebase accordingly. |
|
If you're able to test the branch (and the Refactor download (container))
this would help merging it.
…--
Max Gautier
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
The Gateway API HTTPRoute CRD in experimental channel (v1.5.x+) exceeds Kubernetes' 262144-byte annotation limit when using client-side apply, causing installation failures.
This PR switches the Gateway API installation task from using the
kubemodule (client-side apply) to thecommandmodule withkubectl apply --server-sideto bypass the annotation size limitation.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
--server-side=trueflag is the recommended approach for large CRDs--force-conflictshandles ownership conflicts during upgradesDoes this PR introduce a user-facing change?: