Kubespray with fqcn internal#13333
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: manzsolutions-aleski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @manzsolutions-aleski! |
|
Hi @manzsolutions-aleski. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I will look into the EasyCLI things tomorrow. |
|
Hum I think this would break the no-collection use case ? I had similar problems (making the two co-exists) a while back with a filter 🤔 |
|
Are you talking about this? #11073 Perhaps I'm confused, but it thought it was you who advocated for only-collections: #12227 (comment) |
|
Yes. I do, but that should be an explicit choice (and we also need to convert the CI for it to keep working). |
|
Before I forget it - the linter rule is AI-generated but has been tested, cleaned up and refactored using ruff by me. |
|
EasyCLA signed. ✅ |
|
/ok-to-test |
What type of PR is this?
What this PR does / why we need it:
In newer ansible releases using the short task name breaks. Therefore use the full task name and introduce a lint rule to prevent regressions.
Which issue(s) this PR fixes:
Fixes #13332
Special notes for your reviewer:
Does this PR introduce a user-facing change?: