Fix mixed content issue for browser connection - #215
Open
helly0d wants to merge 1 commit into
Open
Conversation
Contributor
|
Bit of an old PR (thanks for submitting the change)... but would be cool if we could potentially get some tests around this for before/after and then can merge. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When leap motion is not active and the SDK is loaded on a
httpspage, all the browsers will throw error regardingmixed content.The issue was from the attempt to degrade from
wsstowsif the connection to the web socket failed, butwsis insecure and is not allowed withhttps.