Skip to content

Update jupyter-html deps (major) #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
+766 −638
Open

Update jupyter-html deps (major) #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions livekit-rtc/jupyter-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,17 @@
"react-dom": "^19.2.4"
},
"devDependencies": {
"@eslint/js": "^9.39.3",
"@eslint/js": "^10.0.0",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"@vitejs/plugin-react": "^4.7.0",
"eslint": "^9.39.3",
"eslint-plugin-react-hooks": "^5.2.0",
"@vitejs/plugin-react": "^6.0.0",
"eslint": "^10.0.0",
"eslint-plugin-react-hooks": "^7.0.0",
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
"eslint-plugin-react-refresh": "^0.5.0",
"globals": "^17.0.0",
"typescript": "~5.9.0",
"typescript": "~7.0.0",

@devin-ai-integration devin-ai-integration Bot Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 TypeScript pinned to a version that does not match the intended upgrade, breaking dependency install

The TypeScript dependency is set to ~7.0.0 (livekit-rtc/jupyter-html/package.json:28) instead of the intended ~6.0.0, so installing the project's dependencies will fail because no matching TypeScript release exists for that range.
Impact: Anyone installing or building the jupyter-html project cannot fetch a valid TypeScript version, causing the install/build to fail.

Version-range mismatch between stated upgrade and applied change

This PR is a Renovate major dependency bump. The PR description table lists TypeScript as ~5.9.0 → ~6.0.0, and the merge-confidence badge URLs reference typescript/6.0.3. However the applied change at livekit-rtc/jupyter-html/package.json:28 writes "typescript": "~7.0.0". The ~7.0.0 range requires a 7.0.x release; since the intended target was the 6.0.x line, this range will not resolve to any expected published version and diverges from the rest of the coordinated upgrade (@vitejs/plugin-react ^6.0.0, eslint ^10.0.0, vite ^8.0.0). This is an incorrect/inconsistent transformation relative to the PR's stated intent.

Suggested change
"typescript": "~7.0.0",
"typescript": "~6.0.0",
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"typescript-eslint": "^8.56.1",
"vite": "^6.4.1",
"vite": "^8.0.0",
"vite-plugin-singlefile": "^2.3.0"
}
}
Loading
Loading