Skip to content

use SecureRandom for web socket mask keys #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basavaraj-sm05 wants to merge 1 commit into from
+2 −2
Closed

use SecureRandom for web socket mask keys #9624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions okhttp/src/commonJvmAndroid/kotlin/okhttp3/OkHttpClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ package okhttp3
import java.net.Proxy
import java.net.ProxySelector
import java.net.Socket
import java.security.SecureRandom
import java.time.Duration
import java.util.Random
import java.util.concurrent.ExecutorService
import java.util.concurrent.TimeUnit
import java.util.concurrent.TimeUnit.MILLISECONDS
Expand Down Expand Up @@ -363,7 +363,7 @@ open class OkHttpClient internal constructor(
taskRunner = taskRunner,
originalRequest = request,
listener = listener,
random = Random(),
random = SecureRandom(),
pingIntervalMillis = pingIntervalMillis.toLong(),
// extensions is always null for clients:
extensions = null,
Expand Down
Loading