Skip to content

Fix LLC center-mask fallback and fixture schema - #820

Merged
alxmrs merged 2 commits into
mainfrom
agent/fix-llc-fixture-hfacc
Jul 30, 2026
Merged

Fix LLC center-mask fallback and fixture schema#820
alxmrs merged 2 commits into
mainfrom
agent/fix-llc-fixture-hfacc

Conversation

@jder

@jder jder commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

  • align the tiny LLC test fixture with the live LLC4320 root's complete variable/coordinate set, dimension layouts, and mask dtypes
  • preserve mask_c as the preferred center mask while falling back to hFacC when mask_c is absent
  • add regression coverage for the production schema and the unresolved hFacC fallback from PR Add LLC CPU data canonicalization #670

Root cause

LLC canonicalization hard-coded mask_c in its retained-variable whitelist. The test fixture omitted hFacC, so it could not expose that stores containing only the standard MITgcm center-cell fraction would drop their only center wet mask before canonicalization.

The live LLC4320 root contains both mask_c and hFacC; the fixture now models both accurately, including fractional float32 hFac* arrays.

Validation

  • uv run pytest tests/test_utils_data.py -k llc — 7 passed
  • uv run pytest tests/test_config.py tests/test_datasets.py -k llc — 9 passed
  • pre-commit Ruff and mypy hooks passed; Ruff formatting was applied
  • the remaining schema hook was interrupted on the slow shared host; GitHub CI should complete the full suite

Review context: #670 (comment)

@jder
jder marked this pull request as ready for review July 24, 2026 15:12
@jder
jder requested a review from alxmrs July 24, 2026 15:21

@alxmrs alxmrs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@alxmrs
alxmrs added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit afbe394 Jul 30, 2026
20 checks passed
@alxmrs
alxmrs deleted the agent/fix-llc-fixture-hfacc branch July 30, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants