Fix relay file directory decoding and preserve exact RCB options#36
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field defects fixed
FRA00019.cfgandFRA00019.dat, lost the nested file attributes, and produced the observed singleCFG / Missing DAT / size unknownrow.TrgOpsandOptFldsvalues are often returned as MMS bit strings such asbits(08, unused=2). The exporter previously searched those strings for words, forced GI=true, and omittedbufOvfl, so exported CID options did not match the IED.Changes
[0] -> SEQUENCE OF DirectoryEntryand direct-entry layouts without collapsing companion filesRegression coverage
COMTRADE/FRA00019.cfgand.datreturns two files with their sizesbits(08, unused=2)is exported as GI onlybits(0200, unused=6)is exported with onlybufOvfl=trueNo runtime RCB write or reservation is added; the new export evidence remains read-only.