fix(guardians): detect per-service stryker config in monorepos#2
Merged
Conversation
hasMutationRatchet checked only the repo root, so a monorepo with per-service stryker configs (services/<svc>/api/stryker.config.json — the bsk pilot layout) was a systematic false negative, forcing guardian overrides. Replace with a bounded (depth 3), node_modules/hidden-dir-skipping scan so an adopted ratchet in at least one package registers as the repo-level guardian signal. New fixture + test cover the per-service layout; the root and missing cases are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hasMutationRatchetprüfte nur das Repo-Root auf eine Stryker-Config. In einem Monorepo mit per-Service-Configs (services/<svc>/api/stryker.config.json— das bsk-Pilot-Layout) war das ein systematisches False-Negative:checkGuardiansmeldetemutation-ratchetfehlend, obwohl der Ratchet pro Service existiert → jede T3-PR brauchte einen Guardian-Override (REFUSE_GUARDIANS/protected-set-Umweg), obwohl die Vorbedingung faktisch erfüllt war.Fix
Bounded (Tiefe 3),
node_modules-/hidden-dir-überspringende Suche → eine im Repo für mindestens ein Package adoptierte Ratchet-Config registriert als das grobe repo-level „the guardian stands"-Signal (konsistent mit den anderen Detektoren). Reicht bisservices/<svc>/api/- undpackages/<pkg>/-Layouts.Tests
repo-stryker-in-service(Stryker inservices/foo-service/api/, andere Wächter am Root) + Test: wird als vollständig erkannt.dist/neu gebaut (committed).Kontext
Das v0-Detektions-Kontrakt-"tighten per Obol later" (§5) — hier kalibriert gegen das bsk-Monorepo, nachdem 4 Services (link, location, monitoring, feedback) durch die Kette liefen und jedes Mal den Root-only-Override brauchten.
🤖 Generated with Claude Code