docs: add extension in readme - #58
Conversation
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive 'Extensions Section' to the profile/README.md, detailing the organizational structure of Meshery and highlighting several community-driven extensions. A structural HTML issue was identified where an extra closing div tag prematurely terminates the root container, which would disrupt the document's layout and leave orphaned tags later in the file.
| </div> | ||
| </div> |
There was a problem hiding this comment.
The additional </div> tag on line 230 prematurely closes the root container <div> that begins on line 1. This disrupts the document structure, causing the subsequent 'Community and Contributing' and 'Footer' sections to be rendered outside the main container, and leaves an orphaned closing </div> tag at the end of the file (line 262).
| </div> | |
| </div> | |
| </div> |
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
|
@suzy-g38 pretty good add-ons . |
will make the changes shortly |
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
|
@chellej @banana-three-join I have fixed the issues, can you check |
|
@suzy-g38 - Small review comment: You need to correct the logo url so that it is shown properly: There is no |
Sure |
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
|
@matrixkavi I have made the changes, can you look into it? |
|
@banana-three-join @matrixkavi can you merge this pr then? |
|
@suzy-g38 Sorry I don't have enough rights to merge. 😖 |
leecalcote
left a comment
leecalcote
left a comment
There was a problem hiding this comment.
@sangramrath, assuming that you might get a moment tomorrow to have a look at this (here is what the current changes look like - https://github.com/suzy-g38/.github/blob/e2d44ad565f2493b08903babbc8ff1275a5da37f/profile/README.md)
, I will offer a couple of thoughts that we might want to consider:
- I'll suggest that where we should ensure that this readme foremost convey's a description of Meshery Extensions, not Meshery.
- @suzy-g38, I'll suggest that we either list all extensions or none at all. The static set of six most popular is will get outdated and is doesn't offer an equal representation.
|
@sangramrath should I go with adding all the extensions, I found there are total 20 extensions or none of them? as initially in the description it mentioned top 5, so based on that I added them. But now each of the case has their own good and bad. Can you suggest me? |
|
@suzy-g38 none of the 5 mentioned are the top 5 at the moment (IMO). The last release (and push) for all of these were in the early-mid 2025. |
|
@sangramrath no, sir. We do not. |
|
@suzy-g38 any updates here? |
|
@sangramrath Actually the meshery docker extension link is a bit tough to find out. That's why it is getting a bit late |
Signed-off-by: suzy-g38 <sulagnaghosh52.github@gmail.com>
|
@sangramrath I have made the changes, can you check? |
|
Some overlap and duplication with #63 |
|
Thanks for your contribution to Meshery! 🎉
|
7 participants
Notes for Reviewers
This PR contains information for
This PR fixes #57
Signed commits