FIX Correct Round Robin target identity matching#2225
Open
romanlutz wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0162bbcb-1620-4d09-ac1c-7cfa9ae5046f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Historical
RoundRobinTargetattacks could be incorrectly treated as cross-target and made read-only. Their persisted rootmodel_nameis null, while the active target UI derives the shared inner model name, so the previous display-field comparison produced a false mismatch.This change exposes the persisted objective target's canonical
ComponentIdentifierhash and uses it consistently for frontend cross-target checks and backend message validation. Freshly created attack state also retains the hash. Because the hash includes Round Robin weights and all inner target identifiers, matching composites remain writable while genuinely incompatible composites are still rejected.Tests and Documentation