[BUILD-1756] feat: support pushing output images to OpenShift imagestreams

[psrvere]

Summary

• Convert ImageStreamTag output to internal registry URL (image-registry.openshift-image-registry.svc:5000/<namespace>/<name>:<tag>) instead of warning "not supported"
• Emit info log with the converted URL for visibility
• Warn when no explicit pushSecret is set (user needs a ServiceAccount with registry push access)
• Default to :latest tag when ImageStreamTag name has no colon (matches OpenShift behavior)
• Remove the ImageStreamsPushRFE constant from rfe.go (feature now implemented)

Test plan

• Unit tests: 76/76 PASS (includes new test cases for cross-namespace, tagless, with/without pushSecret)
• Cluster test: BuildConfig (IST output) → crane convert → Shipwright Build → BuildRun push → PASS
• Image pull verification: Pod pulled image from internal registry, content matched expected output
• Cluster: OpenShift 4.20.0-0.nightly-2026-07-15-212908

Related

• Jira: https://issues.redhat.com/browse/BUILD-1756

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • ImageStreamTag outputs now default to the latest tag when no tag is provided.
  • ImageStreamTag references support custom and cross-namespace targets.
  • Informational messages clarify image conversion behavior.

• Bug Fixes

  • Added a warning when no push secret is configured for ImageStreamTag outputs.

[coderabbitai]

📝 Walkthrough

Walkthrough

ImageStreamTag output conversion now defaults missing tags to latest, builds URLs from normalized references, and conditionally warns about missing push secrets. Tests cover namespace and secret combinations, while an obsolete RFE constant is removed.

Changes

ImageStreamTag output conversion

Layer / File(s)	Summary
Normalize ImageStreamTag outputs convert/buildconfigs.go, convert/rfe.go	ImageStreamTag names without tags receive :latest; normalized names are used for internal registry URLs, push-secret warnings are conditional, and ImageStreamsPushRFE is removed.
Cover ImageStreamTag cases convert/buildconfigs_test.go	Tests cover custom namespaces, push secrets, cross-namespace references, and default latest tags.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding support for pushing output images to OpenShift imagestreams.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

convert/buildconfigs_test.go (1)

390-391: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Rename test case to avoid a duplicate name.

There is already an existing test case at line 307 named "ImageStreamTag output with pushSecret". To distinguish this test and more accurately reflect its specific scenario, consider appending - custom namespace to the name, similar to the preceding test case.

♻️ Proposed refactor

 		{
-			name: "ImageStreamTag output with pushSecret",
+			name: "ImageStreamTag output with pushSecret - custom namespace",

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@convert/buildconfigs_test.go` around lines 390 - 391, Rename the duplicate
test case in the test table to distinguish its custom-namespace scenario,
appending “- custom namespace” to the existing “ImageStreamTag output with
pushSecret” name while leaving the test logic unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@convert/buildconfigs_test.go`:
- Around line 390-391: Rename the duplicate test case in the test table to
distinguish its custom-namespace scenario, appending “- custom namespace” to the
existing “ImageStreamTag output with pushSecret” name while leaving the test
logic unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c2e128de-5945-45d7-b16b-1f079fd3cfa3

📥 Commits

Reviewing files that changed from the base of the PR and between 99125df and d7e81f9.

📒 Files selected for processing (3)

• convert/buildconfigs.go
• convert/buildconfigs_test.go
• convert/rfe.go

💤 Files with no reviewable changes (1)

• convert/rfe.go