[BUILD-1607] feat: map S2I Incremental flag to incremental param

[psrvere]

Summary

• Maps the S2I Incremental flag from BuildConfig sourceStrategy to the Shipwright incremental parameter on the converted Build
• Parameter is only set when the flag is explicitly present in the BuildConfig; unset flag adds no parameter (strategy default applies)
• Follows the established forcePull → pull-policy mapping pattern (BUILD-1606)

Test plan

• Unit tests: 88/88 PASS (GOWORK=off go test ./convert/...) — covers true/false/nil Incremental cases
• Cluster e2e: BuildConfig converted on OpenShift, BuildRun succeeded with incremental param set, artifact reuse verified via cached image layers

Related

• Jira: https://issues.redhat.com/browse/BUILD-1607

🤖 Generated with Claude Code

[coderabbitai]

📝 Walkthrough

Walkthrough

The source-strategy conversion now maps enabled S2I incremental builds to a Shipwright incremental=true parameter. Tests cover true, false, and nil values, while the obsolete incremental-build RFE constant is removed.

Changes

S2I incremental conversion

Layer / File(s)	Summary
Incremental parameter mapping and validation convert/buildconfigs.go, convert/buildconfigs_test.go, convert/rfe.go	The source-strategy conversion adds the incremental parameter only when S2I incremental mode is explicitly true, with unit coverage for true, false, and nil values. The obsolete incremental-build RFE constant is removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• migtools/crane-lib#148: Adds a related source-strategy helper and parameter mapping for another S2I option.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: mapping the S2I Incremental flag to the Shipwright incremental parameter.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}