Skip to content

🧪 Fix mta 801 test failing on OCP - #677

Draft
stillalearner wants to merge 1 commit into
migtools:mainfrom
stillalearner:fix_mta801
Draft

🧪 Fix mta 801 test failing on OCP#677
stillalearner wants to merge 1 commit into
migtools:mainfrom
stillalearner:fix_mta801

Conversation

@stillalearner

@stillalearner stillalearner commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Fixed mta 801

Summary by CodeRabbit

  • Bug Fixes
    • Improved stateful migration validation across OpenShift and non-OpenShift platforms.
    • Updated manifest comparisons to use platform-specific expected outputs.
    • Enhanced export comparisons to correctly handle platform-generated resources and optional identities.
    • Reduced false differences for OpenShift role bindings, service accounts, config maps, and secrets.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b419f014-a8bd-4912-94a2-6e182d0ce6f7

📥 Commits

Reviewing files that changed from the base of the PR and between 66d279e and aa8aa64.

📒 Files selected for processing (2)
  • e2e-tests/tests/tier0/mta_801_stateful_migration_test.go
  • e2e-tests/utils/utils.go

📝 Walkthrough

Walkthrough

The stateful migration test now detects OpenShift and uses platform-specific golden manifests and YAML comparison behavior. Export comparison utilities recognize OpenShift system RoleBinding identities as optional alongside existing optional resources.

Changes

Stateful migration platform handling

Layer / File(s) Summary
Platform-aware migration comparison
e2e-tests/tests/tier0/mta_801_stateful_migration_test.go, e2e-tests/utils/utils.go
The test selects OpenShift or non-OpenShift golden directories and export comparators; optional identity matching includes OpenShift system RoleBinding resources.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: test

Suggested reviewers: midays, aufi

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and clearly matches the main change: fixing the MTA 801 test failure on OpenShift.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant