test(core): guard Bedrock admission startup path by robinbraemer · Pull Request #61 · minekube/connect-java

robinbraemer · 2026-07-23T07:37:21Z

Intent

Harden the regression guard for the connect-java 0.12.0 Paper/Spigot startup crash (moxy#470; code already fixed in 0.12.1 / PR #59). Root cause: BedrockIdentityEnforcer and BedrockIdentityKeyProvider injected ConnectConfig directly, and they are resolved by the config-agnostic parent/platform injector while SpigotPlatform is constructed (before ConnectPlatform.init() loads config), forcing a JIT ConnectConfig binding on the parent that then collided (JitBindingAlreadySet) with the child ConfigLoadedModule binding — so onLoad crashed and token.json was never generated. 0.12.1 fixed the code by resolving config lazily via ConfigHolder. I verified 0.12.1 fully fixes the crash by reproducing on the 0.12.0 release commit (the graph is unresolvable from a config-agnostic parent) and confirming main passes. This change is TEST-ONLY: the existing BedrockParentInjectorStartupTest guard only exercised the enforcer path, but the bug report and SpigotPlatform/ConnectPlatform inject BedrockAdmissionCoordinator directly. I added a second test method (and extracted shared parent-injector/assertion helpers) that resolves BedrockAdmissionCoordinator from the pre-config parent and asserts the parent stays ConnectConfig-agnostic, closing the coverage gap for the exact injection point named in the report. No production code changed.

What Changed

Added regression coverage that resolves BedrockAdmissionCoordinator from the pre-configuration parent injector and verifies it remains ConnectConfig-agnostic.
Extracted shared parent-injector setup and assertions while retaining the existing enforcer-path guard.

The full validation pipeline passed.

Risk Assessment

✅ Low: The change is narrowly scoped to test-only injector coverage, preserves the existing guard, and adds the requested direct BedrockAdmissionCoordinator startup-path check.

Testing

The focused regression test passed for both enforcer and coordinator paths; the independent runtime check confirmed coordinator resolution, no parent ConnectConfig binding, and successful child config binding. Evidence was preserved and generated build/cache directories were removed; no UI surface exists for this backend injector change.

Evidence: Runtime startup smoke check

PRE_CONFIG_PARENT coordinator resolution: OK PRE_CONFIG_PARENT ConnectConfig binding: null POST_INIT_CHILD ConnectConfig is loaded instance: true

jshell> jshell> jshell> jshell> jshell> jshell> jshell> PRE_CONFIG_PARENT coordinator resolution: OK
jshell> PRE_CONFIG_PARENT ConnectConfig binding: null
jshell> jshell> jshell> POST_INIT_CHILD ConnectConfig is loaded instance: true
jshell> jshell>

Evidence: Gradle test report

<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<meta http-equiv="x-ua-compatible" content="IE=edge"/>
<title>Test results - BedrockParentInjectorStartupTest</title>
<link href="../css/base-style.css" rel="stylesheet" type="text/css"/>
<link href="../css/style.css" rel="stylesheet" type="text/css"/>
<script src="../js/report.js" type="text/javascript"></script>
</head>
<body>
<div id="content">
<h1>BedrockParentInjectorStartupTest</h1>
<div class="breadcrumbs">
<a href="../index.html">all</a> &gt; 
<a href="../packages/com.minekube.connect.module.html">com.minekube.connect.module</a> &gt; BedrockParentInjectorStartupTest</div>
<div id="summary">
<table>
<tr>
<td>
<div class="summaryGroup">
<table>
<tr>
<td>
<div class="infoBox" id="tests">
<div class="counter">2</div>
<p>tests</p>
</div>
</td>
<td>
<div class="infoBox" id="failures">
<div class="counter">0</div>
<p>failures</p>
</div>
</td>
<td>
<div class="infoBox" id="ignored">
<div class="counter">0</div>
<p>ignored</p>
</div>
</td>
<td>
<div class="infoBox" id="duration">
<div class="counter">0.291s</div>
<p>duration</p>
</div>
</td>
</tr>
</table>
</div>
</td>
<td>
<div class="infoBox success" id="successRate">
<div class="percent">100%</div>
<p>successful</p>
</div>
</td>
</tr>
</table>
</div>
<div id="tabs">
<ul class="tabLinks">
<li>
<a href="#tab0">Tests</a>
</li>
</ul>
<div id="tab0" class="tab">
<h2>Tests</h2>
<table>
<thead>
<tr>
<th>Test</th>
<th>Duration</th>
<th>Result</th>
</tr>
</thead>
<tr>
<td class="success">resolvingAdmissionCoordinatorDoesNotBindConfigOnParentInjector()</td>
<td class="success">0.272s</td>
<td class="success">passed</td>
</tr>
<tr>
<td class="success">resolvingBedrockGraphDoesNotBindConfigOnParentInjector()</td>
<td class="success">0.019s</td>
<td class="success">passed</td>
</tr>
</table>
</div>
</div>
<div id="footer">
<p>
<div>
<label class="hidden" id="label-for-line-wrapping-toggle" for="line-wrapping-toggle">Wrap lines
<input id="line-wrapping-toggle" type="checkbox" autocomplete="off"/>
</label>
</div>Generated by 
<a href="http://www.gradle.org">Gradle 8.5</a> at Jul 23, 2026, 9:26:28 AM</p>
</div>
</div>
</body>
</html>

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

./gradlew :core:test --tests com.minekube.connect.module.BedrockParentInjectorStartupTest --rerun-tasks --console=plain
Direct runtime smoke check resolving BedrockAdmissionCoordinator before config load, then binding ConnectConfig in a child injector
./gradlew :core:clean :api:clean :build-logic:clean --console=plain
Final git status and transient-output checks

✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

… path

@singleton

* fix(core): use Guice-native inject annotations for Bedrock DI Velocity 4.0.0 fails to load the Connect plugin ("Cant create plugin connect") because Guice cannot provision BedrockIdentityKeyProvider, the 2nd parameter of CommonModule.bedrockIdentityReadiness on the VelocityPlugin injector. Root cause: the Velocity plugin does not shade Guice (it is `provided`) and VelocityPlugin builds a child of Velocity's own injector, so it runs on the platform's Guice. Velocity 4.0.0 provides Guice 7, which dropped javax.inject support and recognizes only com.google.inject/jakarta.inject annotations. BedrockIdentityKeyProvider and BedrockAdmissionCoordinator were annotated with javax.inject.Inject/@singleton, so under Guice 7 they have no discoverable @Inject constructor and no no-arg constructor and cannot be provisioned — failing the whole injector. Spigot/Bungee shade Guice 6 and Velocity 3.x ships Guice 5; both still accept javax, so only Velocity 4.0.0 broke. The javax dependency was introduced in #59 (which replaced an explicit @provides factory with a JIT javax.inject.Inject constructor), not #61. Switch the five DI classes that still used javax.inject (BedrockIdentity- KeyProvider, BedrockAdmissionCoordinator, BedrockIdentityEnforcer, VerifiedBedrockIdentityRegistry, Metrics) to their com.google.inject.* equivalents — the codebase standard everywhere else. This is portable across Guice 5/6/7 and changes no DI semantics. Add BedrockVelocityGuice7ProvisioningTest, which replicates Guice 7's injectable-constructor discovery rule and forbids javax.inject on these graph classes (no Guice 7 / Velocity 4.0.0 harness is on the classpath; Guice 6 masks the failure). It fails before this change and passes after. * no-mistakes(document): Documentation and lint housekeeping complete

robinbraemer added 2 commits July 23, 2026 09:18

test(core): guard BedrockAdmissionCoordinator parent-injector startup…

e4bc3f2

… path

no-mistakes(document): Wrapped test lines; no unresolved docs or lint

310a6bb

robinbraemer merged commit 6764c71 into main Jul 24, 2026
1 check passed

robinbraemer mentioned this pull request Jul 24, 2026

fix(core): support Velocity 4 Guice injection #64

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(core): guard Bedrock admission startup path#61

test(core): guard Bedrock admission startup path#61
robinbraemer merged 2 commits into
mainfrom
fm/connect-java-bedrock-admission-startup-guard

robinbraemer commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

robinbraemer commented Jul 23, 2026

Intent

What Changed

Risk Assessment

Testing

Pipeline

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant