Skip to content

fix(everything): close streamable HTTP transports on SIGINT#4530

Open
dev-willbird1936 wants to merge 1 commit into
modelcontextprotocol:mainfrom
dev-willbird1936:fix/everything-streamable-http-sigint-cleanup
Open

fix(everything): close streamable HTTP transports on SIGINT#4530
dev-willbird1936 wants to merge 1 commit into
modelcontextprotocol:mainfrom
dev-willbird1936:fix/everything-streamable-http-sigint-cleanup

Conversation

@dev-willbird1936

Copy link
Copy Markdown

Description

Fix Streamable HTTP shutdown so SIGINT closes every active transport. The session registry is a Map, but the previous for-in loop never enumerated its entries.

Root cause

Shutdown cleanup did not iterate Map entries, so active transports could remain registered and their close hooks were skipped.

Testing

  • Focused Vitest regression with two active transports: 1/1 passed.
  • Full Everything Vitest suite: 108/108 passed across 6 files.
  • Fresh recheck on 2026-07-15 repeated the focused test (1/1), full package suite (108/108), and package build successfully.
  • Everything package build and root TypeScript workspace build: passed.
  • LLM-client integration was not exercised; tests use the transport implementation directly.

This is an ordinary correctness/resource-cleanup fix, not a security report. Hosted CI and maintainer review remain pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants