Fix Multipart Upload for /uploads to work - #13
Open
wizapp wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thank you for this! Is this still the case? Is this in the documentation? |
Contributor
|
Uploading activities in the main purpose I was looking into StravaSwift. This looks like a trivial code change so hoping this can get pulled in soon. |
Contributor
|
Can confirm that version 1.0.1 doesn't work, but implementing this change lets me successfully upload .gtx files. Thanks so much @wizapp ! See my fork with version 1.0.2 if you want this fix implemented. @mpclarkson you should consider merging this :) |
Collaborator
|
Great work, thank you! Can you create a pull request by any chance?
…On Tue, Apr 14, 2020 at 4:33 PM dominic ***@***.***> wrote:
Can confirm that version 1.0.1 doesn't work, but implementing this change
lets me successfully upload .gtx files. Thanks so much @wizapp
<https://github.com/wizapp> !
See my fork <https://github.com/DominicHolmes/StravaSwift> with version
1.0.2 if you want this fix implemented.
@mpclarkson <https://github.com/mpclarkson> you should consider merging
this :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2GTWCX6WNT2NCLDSR6QTRMTXE7ANCNFSM4EMN76GA>
.
--
Thank you,
Ludovic Landry
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
For current Strava API, /upload API needs file data to be named "file" in multipart Data. So here is my fix that makes my project working now.
Cheers
Sebastien