Skip to content

build wheels for py 3.14 and runs tests on 3.13 and 3.14 as well#157

Open
apollo13 wants to merge 2 commits into
multikernel:mainfrom
apollo13:py314
Open

build wheels for py 3.14 and runs tests on 3.13 and 3.14 as well#157
apollo13 wants to merge 2 commits into
multikernel:mainfrom
apollo13:py314

Conversation

@apollo13

Copy link
Copy Markdown

Added wheel build for 3.14 and enabled tests for 3.13 and 3.14 as well. Wonder if it would make sense to cut down tests to min/max python versions to reduce resource usage?

@congwang-mk

Copy link
Copy Markdown
Contributor

Thanks for the PR!

I am a bit hesitated to raise the minimum Python version, since we don't need additional effort to support 3.8, I'd prefer to keep it. Do you see any benefit to raise to 3.10?

For the CI matrix, is there a resource usage issue? It only runs on github, locally we only run it against the local version of Python.

@apollo13

Copy link
Copy Markdown
Author

I am a bit hesitated to raise the minimum Python version, since we don't need additional effort to support 3.8, I'd prefer to keep it. Do you see any benefit to raise to 3.10?

Well I usually argue that if people cannot upgrade to a supported Python version they can stay on older versions of the libraries as well. Happy to remove the commit though. That said since wheels aren't published for 3.8/3.9 it would require rust etc anyways, so it is not easy to get running there at all.

For the CI matrix, is there a resource usage issue? It only runs on github, locally we only run it against the local version of Python.

There is no resource usage issue per se for you now. But even if the resources you are using are free they still need to be bought by someone and contribute to an overall higher power consumption etc. Hence my question whether you'd get roughly the same confidence level if only testing for 3.10 and 3.14 (I don't know sandlock well enough to know whether python point releases behave differently enough to break it every other release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants