diagnostics_channel: grow native channel storage#64497
Open
Qard wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64497 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 739 739
Lines 241669 241682 +13
Branches 45543 45554 +11
=======================================
+ Hits 218087 218113 +26
+ Misses 15150 15112 -38
- Partials 8432 8457 +25
🚀 New features to boost your workflow:
|
Every string-named JavaScript channel consumed an entry in the fixed native subscriber array. Creating more than 1,024 channels triggered a CHECK and terminated the process. Allocate slots only for native publishers and grow the aliased buffer when it fills. Refresh the JavaScript view after resizing and preserve the capacity in snapshots. Signed-off-by: Stephen Belanger <admin@stephenbelanger.com>
af80173 to
3a6cf52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every string-named diagnostics channel currently consumes an entry in a fixed
native subscriber array, so creating more than 1,024 channels terminates the
process at a native
CHECK.Only channels used by native publishers now receive native slots, and the
subscriber buffer grows when it fills. This removes the arbitrary crash while
preserving subscriber tracking and snapshot behavior.
cc @nodejs/diagnostics