Skip to content

fix(devtools): drop stale visibility assertion from nuxt-group e2e test#1042

Merged
antfu merged 1 commit into
mainfrom
purple-areas-win
Jul 24, 2026
Merged

fix(devtools): drop stale visibility assertion from nuxt-group e2e test#1042
antfu merged 1 commit into
mainfrom
purple-areas-win

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

Summary

e2e has been failing on every push to main since #1041. That PR disabled
the nuxt:devtools anchor's render-only visibility: 'false' (it broke the
Nuxt group button's defaultChildId fallback, which looks the anchor up
through the same visibility filter), but left nuxt-group.spec.ts asserting
the old visibility: 'false' value in the same commit — so every e2e run
across all four playgrounds failed on that assertion.

This drops the stale assertion and expands the comment to explain why
visibility: 'false' is currently disabled in module-main.ts and what
needs to happen upstream before it (and this assertion) can be restored.

Verification

  • pnpm build
  • PW_PROJECT='*:dev' pnpm test:e2e:dev --grep nuxt-group — passes across
    empty, spa, tab-pinia, tab-seo

🤖 Generated with the help of an agent.

feat(devtools)!: make embedded dock the only client mode (#1041) disabled
the nuxt:devtools anchor's `visibility: 'false'` (its render-only hiding
breaks the Nuxt group button's defaultChildId fallback) but left the e2e
test asserting the old value, failing e2e on every push to main since.
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8957945
Status: ✅  Deploy successful!
Preview URL: https://93137835.nuxt-devtools.pages.dev
Branch Preview URL: https://purple-areas-win.nuxt-devtools.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c7d15efc-8ee6-4ab2-a94d-b88f8527b421

📥 Commits

Reviewing files that changed from the base of the PR and between 412a33d and 8957945.

📒 Files selected for processing (1)
  • tests/e2e/specs/nuxt-group.spec.ts

📝 Walkthrough

Walkthrough

The Nuxt devtools E2E test updates its handling of the nuxt:devtools anchor dock entry. It removes the expectation that the entry has visibility: 'false' and revises the accompanying comment to document the current upstream behavior while preserving the shared iframe and navigation loop.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing a stale visibility assertion from the nuxt-group e2e test.
Description check ✅ Passed The description is directly related and accurately explains the failing e2e assertion and its fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch purple-areas-win

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@antfu
antfu merged commit 6eeec69 into main Jul 24, 2026
6 of 7 checks passed
@antfu
antfu deleted the purple-areas-win branch July 24, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants