feat: add plugin lifecycle registration - #5
Merged
Conversation
Hooks and plugin-owned skills need the same convention-safe registration and upstream contract checks that tools already receive.
Keep safe logging and Hermes tool binding policies in one place so the new lifecycle API cannot drift from existing tool registration.
Prevent a missing required skill from leaving tools or hooks partially active and duplicating callbacks on retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hermes plugins can now register lifecycle hooks and plugin-owned skills through the same convention-safe kit used for tools. The new declarative entrypoint preserves the existing tool-only API while adding payload-safe hook logging, qualified skill declarations, duplicate detection, and an explicit registration inventory.
Registration validates every declaration before touching Hermes state, so a missing required skill cannot leave tools or hooks partially active or duplicate callbacks on retry. The contract suite now exercises real
PluginContextandPluginManagerbehavior against upstream Hermes and treats an explicit checkout import failure as a failing compatibility signal.Validation
make test— 30 tests pass locally; stale local Hermes contract tests skipmake build— wheel and source distribution build successfullygit diff --check— clean