chore: Re-activate persist-credentials for release jobs - #2277
Merged
Conversation
Signed-off-by: Daniel Azuma <dazuma@gmail.com>
dazuma
requested review from
a team,
fbogsany,
kaylareopelle,
mwear,
robbkidd,
robertlaurin and
xuan-cao-swi
as code owners
August 4, 2026 19:06
kaylareopelle
approved these changes
Aug 4, 2026
kaylareopelle
left a comment
kaylareopelle
left a comment
Contributor
There was a problem hiding this comment.
This looks good based on other OTel repos that enable persist-credentials for some workflows: https://github.com/search?q=org%3Aopen-telemetry+%22persist-credentials%3A+true%22&type=code
mwear
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zizmor change (#2251) broke the release jobs by withholding git credentials and preventing git pushes. This change explicitly grants those credentials. I believe I've included the needed "disable" comments, but someone with more knowledge of zizmor might need to review.