fix(deps): keep Hermit on patched web packages - #25
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 28, 2026, 2:56 AM ET / 06:56 UTC. ClawSweeper reviewWhat this changesThe PR updates Hermit’s React Router and PostCSS dependencies, adds a root PostCSS override for transitive installs, and refreshes the Bun lockfile. Merge readinessKeep this PR open for member review. The branch is a narrow security-maintenance update and current Priority: P2 Review scores
Verification
How this fits togetherHermit’s web application depends on React Router at runtime and PostCSS in its CSS build pipeline. flowchart LR
A[Application source] --> B[package.json dependency policy]
B --> C[Bun dependency resolver]
C --> D[bun.lock resolved packages]
D --> E[React Router runtime]
D --> F[PostCSS CSS build pipeline]
E --> G[Hermit web application]
F --> G
Decision needed
Why: The override is an intentional dependency-policy choice that affects every transitive PostCSS consumer; the supplied patch does not show why the broader pin is required. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Confirm the advisories and resolved dependency graph, then land this small Bun-managed update once a clean install and production CSS build demonstrate that the override preserves Hermit’s current web behavior. Do we have a high-confidence way to reproduce the issue? Not applicable as a user-facing bug reproduction: this PR is a dependency-security update, and the relevant verification is a clean dependency resolution plus a real CSS build/runtime check. Is this the best way to solve the issue? Unclear: updating the vulnerable direct packages is a narrow solution, but the supplied evidence does not yet establish that a repository-wide PostCSS override is necessary rather than a direct-version and lockfile update. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c2ff35ab8681. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
Maintainer dependency sign-off: the repository-wide PostCSS floor is intentional because the advisory is reachable through both direct and transitive CSS tooling. Exact head |
What Problem This Solves
Resolves vulnerable React Router and PostCSS versions in Hermit's application and transitive build graph.
Why This Change Was Made
React Router moves to 8.3.0 and PostCSS to 8.5.23, with a root override keeping every transitive PostCSS instance on the patched floor.
User Impact
Hermit retains the same behavior while its routing and CSS toolchain use patched releases.
Evidence