[docs-agent] Fix stale future enhancements, document --no-wait flag, fix build path - #110
Conversation
…fix build path - ARCHITECTURE.md: Remove 3 items from Future Enhancements that are already implemented (--dry-run, --output-file, --verbose) - README.md: Document --no-wait flag on all CloudFormation command flag tables (cluster-vpc, cluster-iam, cluster-oidc, bootstrap) - DEVELOPMENT.md: Fix build output path from ./rosactl to ./bin/rosactl - Ran prettier on all modified markdown files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WalkthroughDocumentation updates reformat README option tables, document ChangesDocumentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 10 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/guides/DEVELOPMENT.md`:
- Line 42: Update the remaining development workflow command near the documented
./bin/rosactl path to invoke the binary from ./bin instead of the repository
root, keeping the command consistent with the Makefile output location and the
existing documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift-online/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 5649ec4e-b103-477b-af30-d420c55b8081
📒 Files selected for processing (3)
README.mddocs/architecture/ARCHITECTURE.mddocs/guides/DEVELOPMENT.md
| ``` | ||
|
|
||
| The binary will be available at `./rosactl`. | ||
| The binary will be available at `./bin/rosactl`. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Update the remaining binary path in the development workflow.
Line 42 correctly documents ./bin/rosactl, but line 81 still runs ./rosactl. After make build, that command fails because the Makefile writes the binary to ./bin.
Proposed fix
-./rosactl cluster-vpc create test --region us-east-1 --help
+./bin/rosactl cluster-vpc create test --region us-east-1 --help🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/guides/DEVELOPMENT.md` at line 42, Update the remaining development
workflow command near the documented ./bin/rosactl path to invoke the binary
from ./bin instead of the repository root, keeping the command consistent with
the Makefile output location and the existing documentation.
1 participant
Automated Documentation Update
Changes Made
Three documentation fixes across the CLI repository covering stale content, missing flag documentation, and an incorrect path.
Triggered By
Recent PRs (last 7 days):
--no-waitflag for CloudFormation stack operations — flag was implemented but not documented in README flag tables--no-waitto false for all stack operations — confirmed default valueOverall Validation:
--dry-run), stack outputs export (--output-file), and verbose logging (-v/--verbose). Keeping them listed as future work could lead to duplicate implementation attempts.--no-waitflag to 4 command flag tables (cluster-vpc create/delete, cluster-iam create/delete, cluster-oidc create/delete, bootstrap create). Default isfalse../rosactlto./bin/rosactl(matching the Makefile'sBUILD_DIR=./bin).Undocumented areas noted (for human review):
docs/guides/DEVELOPMENT.mdproject structure tree is missing several directories (nodepool/,clusteroidc/,ec2/,elb/,route53/,session.go). A comprehensive tree update would require listing 40+ files and is better done by a human familiar with the intended level of detail.Generated by Chai Bot documentation update task (weekly validation).
Automated by scheduled task
rosa_hyperfleet_docs_update(instructions:ship_help_bot/shared/instructions/scheduled/rosa_hyperfleet_docs_update.md, run:b1479773, commit:b4cb94ed-dirty)Summary by CodeRabbit
--no-waitoption for VPC, IAM, OIDC, and bootstrap commands.