test/e2e: unpin optional-operators fixture from EOL ocp/4.6 integrated stream#5334
test/e2e: unpin optional-operators fixture from EOL ocp/4.6 integrated stream#5334kaovilai wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughWalkthroughThe optional-operators end-to-end fixture updates bundle substitution targets and changes its integrated stream from OpenShift 4.6 to 4.20. ChangesOptional operators fixture
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 17✅ Passed checks (17 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Updates the optional-operators e2e fixture to use a currently-served OCP integrated stream so the e2e-oo job can resolve tag_specification again and actually exercise the bundle/index build flow.
Changes:
- Bumps
tag_specificationfromocp/4.6(EOL/unserved) toocp/4.20. - Repoints operator manifest pullspec substitutions away from removed metering components to images expected to exist in modern streams (
cli,machine-config-operator), while keeping the substituted pullspec strings the same.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - pullspec: quay.io/openshift/origin-hive:4.6 | ||
| with: metering-hive # operand image, must be present in `stable` imagestream | ||
| with: machine-config-operator # operand image, must be present in `stable` imagestream |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for the fix Tiger! |
88e4024 to
0239d59
Compare
|
New changes are detected. LGTM label has been removed. |
…d stream The e2e-oo suite has failed on every run since at least February 2026: the fixture's tag_specification pins the ocp/4.6 integrated stream, which configresolver no longer serves, so every ci-operator invocation dies at startup with: failed to generate integrated streams: failed to get integrated stream ocp/4.6: got unexpected http 400 status code from configresolver: not a valid integrated stream: ocp/4.6 Bump the integrated stream to ocp/4.20 and point the substitutions that referenced metering components (which no longer exist in current release streams) at components present in every modern stream (cli, machine-config-operator). The substitution pullspec strings are unchanged so they keep matching the bundle manifests under test/manifests/4.6. The base_index (ci/redhat-operator-index:v4.6) and the CSV names asserted by the verify-db steps are left untouched: they describe the content of the test's own bundle and base index, not the release stream. Fixes openshift#5333 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>
0239d59 to
cdf95e7
Compare
|
/retest |
|
@kaovilai: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Note
Responses generated with Claude
Summary
The
e2e-oojob has failed on every run since at least February 2026 (job history): the fixture pinstag_specification: ocp/4.6, an EOL integrated stream that configresolver no longer serves, so all fourTestOptionalOperatorssubtests die at ci-operator startup (Ran for 0s):This means the optional-operators (bundle/index build) path currently has no working e2e coverage.
Changes
tag_specificationbumpedocp/4.6→ocp/4.20(verified:https://config.ci.openshift.org/integratedStream?namespace=ocp&name=4.20returns 200 with 384 tags;4.6returns 400).substitutionswhosewith:targets were metering components (gone from modern release streams) now point at components present in every current stream —cliandmachine-config-operator(both verified present in the ocp/4.20 integrated stream;oauth-proxyalready was). Unprefixed names resolve viaDependencyParts/ImageStreamFortostable:<name>, same as before.pullspec:strings are unchanged so they keep matching the CSV undertest/manifests/4.6— the manifest-replacement behavior the suite exercises is preserved.base_index(ci/redhat-operator-index:v4.6) and the CSV names asserted by theverify-db-*steps are left untouched: they describe the test's own bundle and base-index content, not the release stream.Test plan
e2e-oojob triggered on this PR is the real verification (first run able to get past config resolution since the breakage).Fixes #5333
/cc @droslean
Updates the
e2e-oooptional-operators fixture to use the currently servedocp/4.20stream instead of the obsoleteocp/4.6(switchingtag_specificationtoname: "4.20"), unblocking ci-operator startup so the optional-operators end-to-end tests can execute. It refreshes the fixture’s substitution mappings intest/e2e/optional-operators/optional-operators.yamlby changing the metering-related origin pullspecs to resolve towith: cliand introducing a substitution that resolves towith: machine-config-operator, while keeping the existingoauth-proxymapping, the v4.6 base index, and the CSV assertions unchanged.