[COMMS-876] Single-line/multi-line layout argument for attribute value macros#24257
Draft
akabiru wants to merge 3 commits into
Conversation
Multi-value attributes such as target versions need both block and inline renderings depending on the surrounding text; an optional singleline/multiline macro argument lets authors choose.
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
The macro element's layout argument flows through displayFieldOptions; a singleline option selects a comma-joined display field instead of the one-per-line variants used in the single view context.
Mirrors the web matcher grammar and threads the layout to the export formatter's array separator. Multi-value macros now default to one value per line (markdown hard break) instead of a comma-joined list, matching the web rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://community.openproject.org/wp/COMMS-876
Multi-value attributes such as target versions render one value per line, which does not always fit the text around a macro. Attribute value macros now accept an optional trailing layout argument (
workPackageValue:X:targetVersions:singlelineor:multiline, multi-line being the default) so authors can choose.data-layoutversionattribute mapped to the single-line behaviour