fix: bearer token auth for task-api-server + JSON resilience in database + documentation updation - #378
Open
09Rumaisa wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds authentication to the local task API server and improves database resilience against malformed JSON data.
Related Issue
Fixes #309 (item 2) — Local task API has no authentication
Changes
Security
src/main/task-api-server.ts— Added bearer token auth usingrandomUUID()+timingSafeEqual(prevents timing attacks)src/main/agent-manager.ts— PassTASK_API_TOKENenv var to all three agent child process launch pointsResilience
src/main/database.ts— WrappedparseJsonArrayin try-catch so one corrupt JSON column can't crash all task readssrc/main/database.test.ts— 4 new tests (53 total, all passing)Documentation
AGENTS.md— Removed "not yet implemented" — architecture is fully builtdocs/task-lifecycle.md— Fixedfind_similar_tasksdescription (FTS5 + BM25, not SQL LIKE)docs/mobile-api-spec.md— Fixed skills schema + added 7 undocumented endpoints