Skip to content

Add unit tests for applierGroup.Get#7004

Open
siddhiguptas wants to merge 1 commit into
pipe-cd:masterfrom
siddhiguptas:add-applier-group-get-test
Open

Add unit tests for applierGroup.Get#7004
siddhiguptas wants to merge 1 commit into
pipe-cd:masterfrom
siddhiguptas:add-applier-group-get-test

Conversation

@siddhiguptas

Copy link
Copy Markdown

What this PR does / why we need it:
This PR resolves the TODO: Add test for this applierGroup function comment in pkg/app/piped/executor/kubernetes/applier_group.go.

It introduces a table-driven test suite TestApplierGroupGet in applier_group_test.go to cover the various matching and error-handling conditions of the Kubernetes resource applier routing logic.

Which issue(s) this PR fixes:
Fixes #7003

Does this PR introduce a user-facing change?:

  • How are users affected by this change: None
  • Is this breaking change: No
  • How to migrate (if breaking change): N/A

Signed-off-by: Siddhi905 <siddhigupta811@gmail.com>
@siddhiguptas
siddhiguptas requested a review from a team as a code owner July 10, 2026 14:37
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi @siddhiguptas, welcome to PipeCD and thanks for opening your first pull request!

We’re really happy to have you here

Before your PR gets merged, please check a few important things below.


Helpful resources


DCO Sign-off

All commits must include a Signed-off-by line to comply with the Developer Certificate of Origin (DCO).

In case you forget to sign-off your commit(s), follow these steps:

For the last commit:

git commit --amend --signoff
git push --force-with-lease

For multiple commits:

git rebase --signoff origin/master
git push --force-with-lease

Run checks locally

Before pushing updates, please run:

make check

This runs the same checks as CI and helps catch issues early.


💬 Need help?

If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel.
You can get your Slack invite from: https://communityinviter.com/apps/cloud-native/cncf

Thanks for contributing to PipeCD! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for applierGroup.Get in Kubernetes executor

1 participant