VPLAY-12287 - Defer CC Enable / Disable to avoid Stop delays (#1717) - #1741
Open
gavin-parry wants to merge 1 commit into
Open
VPLAY-12287 - Defer CC Enable / Disable to avoid Stop delays (#1717)#1741gavin-parry wants to merge 1 commit into
gavin-parry wants to merge 1 commit into
Conversation
* VPLAY-12287 - Defer CC Enable / Disable to avoid Stop delays Reason for change: If Streamlock is not available, then apply this setting later. This is to avoid delays during stop sequencing causing timeouts. This also includes some useful debug (for now) for testing. Test Procedure: Check that the EPG stop sequence is not timing out. Risk: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: If Streamlock is not available, then apply this setting later. This is to reduce delays during channel zapping, reducing likelihood of EPG timeouts. Note: This still blocks on Streamlock if in a playing related state (e.g. user invoked subtitle change), since deferred settings are applied during tune.
This also includes some useful future debug for stop timings, since fixing this has pushed delays further into stop calls during channel zapping. E.g. Delays now seen acquiring the async task execution mutex during stop when an async task tune is still in progress, i.e. in SuspendScheduler.
Test Procedure: Check that the EPG stop sequence is not timing out. Check subtitle and CC status changes as expected.