RDKEMW-22188: Eliminating crash happening in gst-plugin loader - #1770
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate a crash in the GStreamer plugin loader by splitting SoC/platform detection into two phases: a dl_init-safe phase (device.properties only) and a post-GStreamer-init phase (plugin registry scan).
Changes:
- Added a Phase 2 API (
SocInterface::InitializePlatformFromPlugins) to perform plugin-based platform detection after GStreamer is initialized. - Refactored
SocInterfacesingleton creation to avoid GStreamer calls during Phase 1, using a globalshared_ptrguarded by a mutex. - Hooked Phase 2 platform initialization into
InterfacePlayerRDK::InitializePlayerGstreamerPlugins().
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| middleware/vendor/SocInterface.h | Declares Phase 2 platform initialization API. |
| middleware/vendor/SocInterface.cpp | Implements two-phase platform detection and mutex-protected singleton storage. |
| middleware/InterfacePlayerRDK.cpp | Calls Phase 2 platform initialization during GStreamer plugin initialization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminating crash happening in gst-plugin loader