Skip to content

fix: honour dashboard rebase for edited branch with no open PR#44567

Open
pose wants to merge 1 commit into
renovatebot:mainfrom
pose:fix/dashboard-rebase-edited-branch-without-pr
Open

fix: honour dashboard rebase for edited branch with no open PR#44567
pose wants to merge 1 commit into
renovatebot:mainfrom
pose:fix/dashboard-rebase-edited-branch-without-pr

Conversation

@pose

@pose pose commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Changes

The Dependency Dashboard's PR Edited (Blocked) checkbox is silently ignored for an edited branch with no open PR: the else if (branchIsModified) block in processBranch() returns pr-edited without consulting dependencyDashboardCheck, unlike every other early return in that function. The dashboard re-renders the branch in the same list with the box unticked, so the request can never take effect.

Skipping that block when a dashboard check is present lets the flow reach userRebaseRequested, which sets reuseExistingBranch = false and recreates the branch from base, as the section's text promises.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non-trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Claude Opus 4.8, via Claude Code: the code change, the two unit tests, and this description. Human-reviewed before submission.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

@cla-assistant

cla-assistant Bot commented Jul 14, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@pose pose force-pushed the fix/dashboard-rebase-edited-branch-without-pr branch 4 times, most recently from 7123e4c to ca5e59e Compare July 14, 2026 10:36
@pose pose marked this pull request as ready for review July 14, 2026 10:37
@github-actions github-actions Bot requested a review from viceice July 14, 2026 10:38
@pose

pose commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

For transparency: I force-pushed this branch a few times while it was still in draft, to fix the commit message and author email. No commits have been amended since it was marked ready for review, and I won't rebase from here.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@pose pose force-pushed the fix/dashboard-rebase-edited-branch-without-pr branch from ca5e59e to f829adf Compare July 14, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant