fix: honour dashboard rebase for edited branch with no open PR#44567
Open
pose wants to merge 1 commit into
Open
fix: honour dashboard rebase for edited branch with no open PR#44567pose wants to merge 1 commit into
pose wants to merge 1 commit into
Conversation
7123e4c to
ca5e59e
Compare
Contributor
Author
|
For transparency: I force-pushed this branch a few times while it was still in draft, to fix the commit message and author email. No commits have been amended since it was marked ready for review, and I won't rebase from here. |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ca5e59e to
f829adf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The Dependency Dashboard's PR Edited (Blocked) checkbox is silently ignored for an edited branch with no open PR: the
else if (branchIsModified)block inprocessBranch()returnspr-editedwithout consultingdependencyDashboardCheck, unlike every other early return in that function. The dashboard re-renders the branch in the same list with the box unticked, so the request can never take effect.Skipping that block when a dashboard check is present lets the flow reach
userRebaseRequested, which setsreuseExistingBranch = falseand recreates the branch from base, as the section's text promises.Context
Please select one of the following:
AI assistance disclosure
Did you use AI tools to create any part of this pull request?
Claude Opus 4.8, via Claude Code: the code change, the two unit tests, and this description. Human-reviewed before submission.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: