Retry file transfers on transient network errors - #198
Open
aszady wants to merge 1 commit into
Open
Conversation
Repository metadata files are susceptible to mid-transfer failures: the download might take long enough for the network infrastucture to time out or for other transient network issues to surface. These are inherently retriable – the server has the file, the connection just dropped. `fetchFile` now wraps the transfer in a retry loop (up to 3 retries). Only genuinely transient errors trigger a retry. HTTP status codes and `Getter.Get` failures are not retried at this layer – `retryablehttp` handles those internally, and by the time an error reaches `fetchFile`, those retries are already exhausted. `WriteToRepoDir` error wrapping is changed from `%v` to `%w` so that `errors.Is` can see through to the underlying cause when classifying errors.
|
aszady
marked this pull request as ready for review
June 25, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository metadata files are susceptible to mid-transfer failures: the download might take long enough for the network infrastucture to time out or for other transient network issues to surface. These are inherently retriable – the server has the file, the connection just dropped.
fetchFilenow wraps the transfer in a retry loop (up to 3 retries). Only genuinely transient errors trigger a retry.HTTP status codes and
Getter.Getfailures are not retried at this layer –retryablehttphandles those internally, and by the time an error reachesfetchFile, those retries are already exhausted.WriteToRepoDirerror wrapping is changed from%vto%wso thaterrors.Iscan see through to the underlying cause when classifying errors.